Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: cc/TreeSynchronizer.h

Issue 11076013: [cc] Store CCLayerImpls as scoped_ptrs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/TreeSynchronizer.h
diff --git a/cc/TreeSynchronizer.h b/cc/TreeSynchronizer.h
index b180dd0bffe29b0733c7a72f424fa19d57f7af12..26098411b94294ee64edf8ccbd0786ec0f6254a1 100644
--- a/cc/TreeSynchronizer.h
+++ b/cc/TreeSynchronizer.h
@@ -6,9 +6,8 @@
#define TreeSynchronizer_h
#include "base/basictypes.h"
-#include <wtf/HashMap.h>
-#include <wtf/OwnPtr.h>
-#include <wtf/PassOwnPtr.h>
+#include "base/memory/scoped_ptr.h"
+#include "cc/scoped_ptr_hash_map.h"
namespace cc {
@@ -20,18 +19,18 @@ class TreeSynchronizer {
public:
// Accepts a LayerChromium tree and returns a reference to a CCLayerImpl tree that duplicates the structure
// of the LayerChromium tree, reusing the CCLayerImpls in the tree provided by oldCCLayerImplRoot if possible.
- static PassOwnPtr<CCLayerImpl> synchronizeTrees(LayerChromium* layerRoot, PassOwnPtr<CCLayerImpl> oldCCLayerImplRoot, CCLayerTreeHostImpl*);
+ static scoped_ptr<CCLayerImpl> synchronizeTrees(LayerChromium* layerRoot, scoped_ptr<CCLayerImpl> oldCCLayerImplRoot, CCLayerTreeHostImpl*);
private:
TreeSynchronizer(); // Not instantiable.
- typedef HashMap<int, OwnPtr<CCLayerImpl> > OwnPtrCCLayerImplMap;
- typedef HashMap<int, CCLayerImpl*> RawPtrCCLayerImplMap;
+ typedef ScopedPtrHashMap<int, CCLayerImpl> ScopedPtrCCLayerImplMap;
+ typedef base::hash_map<int, CCLayerImpl*> RawPtrCCLayerImplMap;
// Declared as static member functions so they can access functions on LayerChromium as a friend class.
- static PassOwnPtr<CCLayerImpl> reuseOrCreateCCLayerImpl(RawPtrCCLayerImplMap& newLayers, OwnPtrCCLayerImplMap& oldLayers, LayerChromium*);
- static void collectExistingCCLayerImplRecursive(OwnPtrCCLayerImplMap& oldLayers, PassOwnPtr<CCLayerImpl>);
- static PassOwnPtr<CCLayerImpl> synchronizeTreeRecursive(RawPtrCCLayerImplMap& newLayers, OwnPtrCCLayerImplMap& oldLayers, LayerChromium*, CCLayerTreeHostImpl*);
+ static scoped_ptr<CCLayerImpl> reuseOrCreateCCLayerImpl(RawPtrCCLayerImplMap& newLayers, ScopedPtrCCLayerImplMap& oldLayers, LayerChromium*);
+ static void collectExistingCCLayerImplRecursive(ScopedPtrCCLayerImplMap& oldLayers, scoped_ptr<CCLayerImpl>);
+ static scoped_ptr<CCLayerImpl> synchronizeTreeRecursive(RawPtrCCLayerImplMap& newLayers, ScopedPtrCCLayerImplMap& oldLayers, LayerChromium*, CCLayerTreeHostImpl*);
static void updateScrollbarLayerPointersRecursive(const RawPtrCCLayerImplMap& newLayers, LayerChromium*);
DISALLOW_COPY_AND_ASSIGN(TreeSynchronizer);

Powered by Google App Engine
This is Rietveld 408576698