[cc] Store CCLayerImpls as scoped_ptrs

cc/TreeSynchronizer.cpp

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "TreeSynchronizer.h"
 
 #include "CCLayerImpl.h"
 #include "CCScrollbarAnimationController.h"
 #include "CCScrollbarLayerImpl.h"
 #include "LayerChromium.h"
 #include "ScrollbarLayerChromium.h"
 
 namespace cc {
 
-PassOwnPtr<CCLayerImpl> TreeSynchronizer::synchronizeTrees(LayerChromium* layerChromiumRoot, PassOwnPtr<CCLayerImpl> oldCCLayerImplRoot, CCLayerTreeHostImpl* hostImpl)
+scoped_ptr<CCLayerImpl> TreeSynchronizer::synchronizeTrees(LayerChromium* layerChromiumRoot, scoped_ptr<CCLayerImpl> oldCCLayerImplRoot, CCLayerTreeHostImpl* hostImpl)
 {
-    OwnPtrCCLayerImplMap oldLayers;
+    ScopedPtrCCLayerImplMap oldLayers;
     RawPtrCCLayerImplMap newLayers;
 
-    collectExistingCCLayerImplRecursive(oldLayers, oldCCLayerImplRoot);
+    collectExistingCCLayerImplRecursive(oldLayers, oldCCLayerImplRoot.Pass());
 
-    OwnPtr<CCLayerImpl> newTree = synchronizeTreeRecursive(newLayers, oldLayers, layerChromiumRoot, hostImpl);
+    scoped_ptr<CCLayerImpl> newTree = synchronizeTreeRecursive(newLayers, oldLayers, layerChromiumRoot, hostImpl);
 
     updateScrollbarLayerPointersRecursive(newLayers, layerChromiumRoot);
 
-    return newTree.release();
+    return newTree.Pass();
 }
 
-void TreeSynchronizer::collectExistingCCLayerImplRecursive(OwnPtrCCLayerImplMap& oldLayers, PassOwnPtr<CCLayerImpl> popCCLayerImpl)
+void TreeSynchronizer::collectExistingCCLayerImplRecursive(ScopedPtrCCLayerImplMap& oldLayers, scoped_ptr<CCLayerImpl> ccLayerImpl)
 {
-    OwnPtr<CCLayerImpl> ccLayerImpl = popCCLayerImpl;
-
     if (!ccLayerImpl)
         return;
 
-    OwnPtrVector<CCLayerImpl>& children = ccLayerImpl->m_children;
+    ScopedPtrVector<CCLayerImpl>& children = ccLayerImpl->m_children;
     for (size_t i = 0; i < children.size(); ++i)
         collectExistingCCLayerImplRecursive(oldLayers, children.take(i));
 
-    collectExistingCCLayerImplRecursive(oldLayers, ccLayerImpl->m_maskLayer.release());
-    collectExistingCCLayerImplRecursive(oldLayers, ccLayerImpl->m_replicaLayer.release());
+    collectExistingCCLayerImplRecursive(oldLayers, ccLayerImpl->m_maskLayer.Pass());
+    collectExistingCCLayerImplRecursive(oldLayers, ccLayerImpl->m_replicaLayer.Pass());
 
     int id = ccLayerImpl->id();
-    oldLayers.set(id, ccLayerImpl.release());
+    oldLayers.set(id, ccLayerImpl.Pass());
 }
 
-PassOwnPtr<CCLayerImpl> TreeSynchronizer::reuseOrCreateCCLayerImpl(RawPtrCCLayerImplMap& newLayers, OwnPtrCCLayerImplMap& oldLayers, LayerChromium* layer)
+scoped_ptr<CCLayerImpl> TreeSynchronizer::reuseOrCreateCCLayerImpl(RawPtrCCLayerImplMap& newLayers, ScopedPtrCCLayerImplMap& oldLayers, LayerChromium* layer)
 {
-    OwnPtr<CCLayerImpl> ccLayerImpl = oldLayers.take(layer->id());
+    scoped_ptr<CCLayerImpl> ccLayerImpl = oldLayers.take(layer->id());
 
     if (!ccLayerImpl)
         ccLayerImpl = layer->createCCLayerImpl();
 
-    newLayers.set(layer->id(), ccLayerImpl.get());
-    return ccLayerImpl.release();
+    newLayers[layer->id()] = ccLayerImpl.get();
+    return ccLayerImpl.Pass();
 }
 
-PassOwnPtr<CCLayerImpl> TreeSynchronizer::synchronizeTreeRecursive(RawPtrCCLayerImplMap& newLayers, OwnPtrCCLayerImplMap& oldLayers, LayerChromium* layer, CCLayerTreeHostImpl* hostImpl)
+scoped_ptr<CCLayerImpl> TreeSynchronizer::synchronizeTreeRecursive(RawPtrCCLayerImplMap& newLayers, ScopedPtrCCLayerImplMap& oldLayers, LayerChromium* layer, CCLayerTreeHostImpl* hostImpl)
 {
     if (!layer)
-        return nullptr;
+        return scoped_ptr<CCLayerImpl>();
 
-    OwnPtr<CCLayerImpl> ccLayerImpl = reuseOrCreateCCLayerImpl(newLayers, oldLayers, layer);
+    scoped_ptr<CCLayerImpl> ccLayerImpl = reuseOrCreateCCLayerImpl(newLayers, oldLayers, layer);
 
     ccLayerImpl->clearChildList();
     const std::vector<scoped_refptr<LayerChromium> >& children = layer->children();
     for (size_t i = 0; i < children.size(); ++i)
         ccLayerImpl->addChild(synchronizeTreeRecursive(newLayers, oldLayers, children[i].get(), hostImpl));
 
     ccLayerImpl->setMaskLayer(synchronizeTreeRecursive(newLayers, oldLayers, layer->maskLayer(), hostImpl));
     ccLayerImpl->setReplicaLayer(synchronizeTreeRecursive(newLayers, oldLayers, layer->replicaLayer(), hostImpl));
 
     layer->pushPropertiesTo(ccLayerImpl.get());
     ccLayerImpl->setLayerTreeHostImpl(hostImpl);
 
     // Remove all dangling pointers. The pointers will be setup later in updateScrollbarLayerPointersRecursive phase
     if (CCScrollbarAnimationController* scrollbarController = ccLayerImpl->scrollbarAnimationController()) {
         scrollbarController->setHorizontalScrollbarLayer(0);
         scrollbarController->setVerticalScrollbarLayer(0);
     }
 
-    return ccLayerImpl.release();
+    return ccLayerImpl.Pass();
 }
 
 void TreeSynchronizer::updateScrollbarLayerPointersRecursive(const RawPtrCCLayerImplMap& newLayers, LayerChromium* layer)
 {
     if (!layer)
         return;
 
     const std::vector<scoped_refptr<LayerChromium> >& children = layer->children();
     for (size_t i = 0; i < children.size(); ++i)
         updateScrollbarLayerPointersRecursive(newLayers, children[i].get());
 
     ScrollbarLayerChromium* scrollbarLayer = layer->toScrollbarLayerChromium();
     if (!scrollbarLayer)
         return;
 
-    CCScrollbarLayerImpl* ccScrollbarLayerImpl = static_cast<CCScrollbarLayerImpl*>(newLayers.get(scrollbarLayer->id()));
+    RawPtrCCLayerImplMap::const_iterator iter = newLayers.find(scrollbarLayer->id());
+    CCScrollbarLayerImpl* ccScrollbarLayerImpl = iter != newLayers.end() ? static_cast<CCScrollbarLayerImpl*>(iter->second) : NULL;

[jamesr, 2012/10/07 22:27:19]

do we really need the iterator? what about just doing
CCScrollbarLayerImpl* ccScrollbarLayerImpl = newLayers[scrollbarLayer->id()];
?

if the entry isn't in the map this will default-construct a null
CCScrollbarLayerImpl*, but we ASSERT() that we don't hit that case anyway

[enne (OOO), 2012/10/07 22:44:57]

Done.  I think it's just personal style to never use [] unless I'm assigning
because of that behavior.

[enne (OOO), 2012/10/07 23:40:23]

Ok, I lied.  You can't operator[] on a const hash_map.  Reverted back to
original.

+    iter = newLayers.find(scrollbarLayer->scrollLayerId());
+    CCLayerImpl* ccScrollLayerImpl = iter != newLayers.end() ? iter->second : NULL;

[jamesr, 2012/10/07 22:27:19]

same here

[enne (OOO), 2012/10/07 22:44:57]

Done.

+
     ASSERT(ccScrollbarLayerImpl);
-    CCLayerImpl* ccScrollLayerImpl = newLayers.get(scrollbarLayer->scrollLayerId());
     ASSERT(ccScrollLayerImpl);
 
     if (ccScrollbarLayerImpl->orientation() == WebKit::WebScrollbar::Horizontal)
         ccScrollLayerImpl->setHorizontalScrollbarLayer(ccScrollbarLayerImpl);
     else
         ccScrollLayerImpl->setVerticalScrollbarLayer(ccScrollbarLayerImpl);
 }
 
 } // namespace cc