OVDA: Perform an egl sync before reusing a texture.

content/common/gpu/media/omx_video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_OMX_VIDEO_DECODE_ACCELERATOR_H_
 #define CONTENT_COMMON_GPU_MEDIA_OMX_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <dlfcn.h>
 #include <map>
 #include <queue>
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
+#include "base/threading/thread.h"

[piman, 2012/10/06 06:42:40]

nit: alpha order

 #include "base/shared_memory.h"
 #include "content/common/content_export.h"
 #include "media/video/video_decode_accelerator.h"
 #include "third_party/angle/include/EGL/egl.h"
 #include "third_party/angle/include/EGL/eglext.h"
 #include "third_party/openmax/il/OMX_Component.h"
 #include "third_party/openmax/il/OMX_Core.h"
 #include "third_party/openmax/il/OMX_Video.h"
 
 class Gles2TextureToEglImageTranslator;
@@ skipping 212 matching lines @@
                                     OMX_PTR priv_data,
                                     OMX_EVENTTYPE event,
                                     OMX_U32 data1, OMX_U32 data2,
                                     OMX_PTR event_data);
   static OMX_ERRORTYPE EmptyBufferCallback(OMX_HANDLETYPE component,
                                            OMX_PTR priv_data,
                                            OMX_BUFFERHEADERTYPE* buffer);
   static OMX_ERRORTYPE FillBufferCallback(OMX_HANDLETYPE component,
                                           OMX_PTR priv_data,
                                           OMX_BUFFERHEADERTYPE* buffer);
+
+  // When we get a texture back via ReusePictureBuffer(), we want to ensure
+  // that its contents have been read out by rendering layer, before we start
+  // overwriting it with the decoder. This thread is used to wait for a sync
+  // object inserted into the command stream at the time of
+  // ReusePictureBuffer. This guarantees that the object is in the stream after
+  // the corresponding texture commands have been inserted into it. Once the
+  // sync object is signalled, we are sure that the stream reached the sync
+  // object, which ensures that all commands related to the texture we are
+  // getting back have been finished as well.
+  base::Thread sync_thread_;
+
+  // Run on the sync_thread_. Wait on the given sync object and post a task
+  // back onto the main thread to queue the texture for reuse.
+  void WaitForPictureSync(int32 picture_buffer_id, EGLSyncKHR egl_sync_obj);
+
+  // Posted onto the main thread by WaitForPictureSync to queue the texture
+  // back for reuse.
+  void QueuePictureBuffer(int32 picture_buffer_id);
 };
 
 #endif  // CONTENT_COMMON_GPU_MEDIA_OMX_VIDEO_DECODE_ACCELERATOR_H_