Issue 1107583005: Take conditionals into account when writing AccessorConfiguration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1107583005: Take conditionals into account when writing AccessorConfiguration (Closed)

Created:
5 years, 8 months ago by rwlbuis

Modified:
5 years, 8 months ago

Reviewers:
haraken, tasak, Yuki

CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Take conditionals into account when writing AccessorConfiguration When generating AccessorConfiguration conditionals should be taken into account just like for instance when generating AttributeConfiguration. Otherwise for example WEB_AUDIO=0 build will not compile. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194379

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/bindings/templates/interface_base.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107583005/1

5 years, 8 months ago (2015-04-24 10:33:35 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 11:43:21 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194379

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages