Issue 110753004: Add a missing animation context to bookmark bar controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110753004: Add a missing animation context to bookmark bar controller. (Closed)

Created:
6 years, 11 months ago by erikchen

Modified:
6 years, 11 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

mac: Add a missing animation context to bookmark bar controller. The animation was not specifying an NSAnimationContext or duration, which meant that the duration was not well defined. I used the same value that I observed on my machine prior to my change. It seems a bit slow, but presumably it's the value most users are seeing. BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243383

Patch Set 1 #

Patch Set 2 : initial #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/110753004/30001

6 years, 11 months ago (2014-01-06 16:34:00 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241916

6 years, 11 months ago (2014-01-06 19:21:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/110753004/30001

6 years, 11 months ago (2014-01-07 18:54:43 UTC) #5

Message was sent while issue was closed.

Change committed as 243383

Expand Messages | Collapse Messages