Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 1107523002: IDL: Drop [PerContextEnabled] extended attribute (Closed)

Created:
5 years, 8 months ago by Jens Widell
Modified:
5 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Drop [PerContextEnabled] extended attribute It is no longer used, and adds complexity to the code generator. BUG=465624 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194275

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -212 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/bindings/scripts/generate_global_constructors.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/interface_dependency_resolver.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 6 chunks +4 lines, -9 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 6 chunks +0 lines, -9 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M Source/bindings/tests/idls/core/TestImplements.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 3 chunks +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/idls/core/TestPartialInterface2.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/modules/TestPartialInterface3.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 3 chunks +1 line, -47 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 5 chunks +0 lines, -98 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jens Widell
PTAL https://codereview.chromium.org/1107523002/diff/1/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (right): https://codereview.chromium.org/1107523002/diff/1/Source/bindings/templates/methods.cpp#newcode632 Source/bindings/templates/methods.cpp:632: {% macro install_conditionally_enabled_methods() %} Turns out we can't ...
5 years, 8 months ago (2015-04-23 05:58:06 UTC) #2
haraken
oh, I didn't know we've already removed customers of [PerContextEnabled]. LGTM.
5 years, 8 months ago (2015-04-23 06:01:57 UTC) #3
Yuki
lgtm. Thanks for doing this. I removed the clients of [PerContextEnabled], but have been lazy ...
5 years, 8 months ago (2015-04-23 06:04:38 UTC) #4
Jens Widell
On 2015/04/23 06:04:38, Yuki wrote: > Thanks for doing this. > I removed the clients ...
5 years, 8 months ago (2015-04-23 06:07:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107523002/1
5 years, 8 months ago (2015-04-23 06:08:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107523002/20001
5 years, 8 months ago (2015-04-23 08:14:47 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 09:47:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194275

Powered by Google App Engine
This is Rietveld 408576698