Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: remoting/BUILD.gn

Issue 1107483002: [Chromoting] Update build-webapp to accept a filelist & update GN rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add 's' to comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/build-webapp.py » ('j') | remoting/webapp/build-webapp.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/BUILD.gn
diff --git a/remoting/BUILD.gn b/remoting/BUILD.gn
index 02adc68d0ab95ec3965cf58a360342a20cca442e..fb75dbaf63c12fcc35a924952c52f9146987f600 100644
--- a/remoting/BUILD.gn
+++ b/remoting/BUILD.gn
@@ -24,12 +24,8 @@ group("remoting_all") {
#"//app_remoting_webapp.gyp:ar_sample_app",
]
- if ((is_linux && !is_chromeos) || is_mac) {
- deps += [
- # TODO(gyp) Enable this for Windows once the webapp can be built without
- # exceeding the 8k cmd line limit on Windows.
- "//remoting/webapp",
- ]
+ if ((is_linux && !is_chromeos) || is_mac || is_win) {
+ deps += [ "//remoting/webapp" ]
}
if (is_win) {
« no previous file with comments | « no previous file | remoting/webapp/build-webapp.py » ('j') | remoting/webapp/build-webapp.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698