Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1107433002: Update {virtual,override} to follow C++11 style in device. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
rpaquay, timvolodine
CC:
chromium-reviews, scheib+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in device. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/77137323157640d3eecae553956425c067054383 Cr-Commit-Position: refs/heads/master@{#326609}

Patch Set 1 #

Patch Set 2 : sync and git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -146 lines) Patch
M device/battery/battery_status_manager_win.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 4 chunks +32 lines, -37 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win_unittest.cc View 1 3 chunks +14 lines, -17 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 2 chunks +31 lines, -34 lines 0 comments Download
M device/bluetooth/bluetooth_socket_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win_unittest.cc View 1 2 chunks +7 lines, -16 lines 0 comments Download
M device/hid/hid_connection_win.h View 1 1 chunk +11 lines, -12 lines 0 comments Download
M device/hid/hid_connection_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/hid/hid_service_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/serial_device_enumerator_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/serial_io_handler_win.h View 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ncarter (slow)
rpaquay: please review
5 years, 8 months ago (2015-04-23 04:36:06 UTC) #2
timvolodine
lgtm device/battery
5 years, 8 months ago (2015-04-23 10:47:07 UTC) #4
rpaquay
lgtm
5 years, 8 months ago (2015-04-23 16:12:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107433002/1
5 years, 8 months ago (2015-04-23 16:50:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58492)
5 years, 8 months ago (2015-04-23 16:57:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107433002/20001
5 years, 8 months ago (2015-04-23 18:28:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 19:40:38 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 19:42:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77137323157640d3eecae553956425c067054383
Cr-Commit-Position: refs/heads/master@{#326609}

Powered by Google App Engine
This is Rietveld 408576698