lib/html/src/dart2js_DOMImplementation.dart - Issue 11074005: Wrap Window in case it's a window from a different page / frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/src/dart2js_DOMImplementation.dart

Issue 11074005: Wrap Window in case it's a window from a different page / frame. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add comment Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/src/dart2js_DOMImplementation.dart

diff --git a/lib/html/src/dart2js_DOMImplementation.dart b/lib/html/src/dart2js_DOMImplementation.dart

index 85bbd46e2d080478773cc00baa120d923b60a57f..955841c2aa488b0be06926565a387e7103f22425 100644

--- a/lib/html/src/dart2js_DOMImplementation.dart

+++ b/lib/html/src/dart2js_DOMImplementation.dart

@@ -63,7 +63,7 @@ class _LocationCrossFrameImpl implements Location {

void set href(String val) => _setHref(_location, val);

static void _setHref(location, val) {

- JS('void', '#.href = #', _location, val);

+ JS('void', '#.href = #', location, val);

}

// Implementation support.

« no previous file with comments | « lib/html/src/dart2js_Conversions.dart ('k') | lib/html/templates/html/dart2js/impl_IFrameElement.darttemplate » ('j') | no next file with comments »