Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1107353003: win: Move HWNDMessageHandler's WeakPtrFactory member to the end. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Move HWNDMessageHandler's WeakPtrFactory member to the end. Fixes some [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. warnings and also makes the code more correct. BUG=303818, 467287 Committed: https://crrev.com/b59e330a7bd6b58bfdfa31690f45aa4485b95e86 Cr-Commit-Position: refs/heads/master@{#327374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M ui/views/win/hwnd_message_handler.h View 5 chunks +8 lines, -7 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 7 months ago (2015-04-28 20:00:48 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-04-28 20:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107353003/1
5 years, 7 months ago (2015-04-28 20:56:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 22:08:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 22:10:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b59e330a7bd6b58bfdfa31690f45aa4485b95e86
Cr-Commit-Position: refs/heads/master@{#327374}

Powered by Google App Engine
This is Rietveld 408576698