Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1107343006: Add a method to enable ChromeVox Next easily for the current run. (Closed)

Created:
5 years, 7 months ago by David Tseng
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a method to enable ChromeVox Next easily for the current run. This cl adds a key sequence that enables ChromeVox Next. Eventually, this can turn into a proper option. TEST=open ChromeVox options page, type 'n', 'e', 'x', 't'. Observe message and ChromeVox Next is enabled on all newly opened tabs. Committed: https://crrev.com/5e949a4ce4b7fff2e8ed7432c247281fddd18a03 Cr-Commit-Position: refs/heads/master@{#327541}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Force next active. #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
David Tseng
5 years, 7 months ago (2015-04-28 20:32:39 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1107343006/diff/40001/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js File chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js (right): https://codereview.chromium.org/1107343006/diff/40001/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js#newcode119 chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js:119: .backgroundObj.forceActive(); How about forceChromeVoxNextActive or forceDesktopAccessibility, or something ...
5 years, 7 months ago (2015-04-29 16:48:39 UTC) #3
David Tseng
 https://codereview.chromium.org/1107343006/diff/40001/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js File chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js (right): https://codereview.chromium.org/1107343006/diff/40001/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js#newcode119 chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js:119: .backgroundObj.forceActive(); On 2015/04/29 16:48:39, dmazzoni wrote: > How ...
5 years, 7 months ago (2015-04-29 18:42:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107343006/80001
5 years, 7 months ago (2015-04-29 18:42:11 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-29 19:14:44 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:16:09 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5e949a4ce4b7fff2e8ed7432c247281fddd18a03
Cr-Commit-Position: refs/heads/master@{#327541}

Powered by Google App Engine
This is Rietveld 408576698