Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1107343004: Update documentation for "COMMIT=false" (Closed)

Created:
5 years, 7 months ago by rmistry
Modified:
5 years, 7 months ago
Reviewers:
jcgregorio, hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update documentation for "COMMIT=false". The meaning of "COMMIT=false" was changed in https://code.google.com/p/chromium/issues/detail?id=470609. I have also updated the corresponding Chromium documentation in https://sites.google.com/a/chromium.org/dev/developers/testing/commit-queue BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1107343004 Committed: https://skia.googlesource.com/skia/+/38620209ca67535686c6b62a2185254ef119196a

Patch Set 1 : Initial upload #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M site/dev/contrib/cqkeywords.md View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmistry
5 years, 7 months ago (2015-04-28 16:44:08 UTC) #2
hcm
One nit, then lgtm https://codereview.chromium.org/1107343004/diff/1/site/dev/contrib/cqkeywords.md File site/dev/contrib/cqkeywords.md (right): https://codereview.chromium.org/1107343004/diff/1/site/dev/contrib/cqkeywords.md#newcode10 site/dev/contrib/cqkeywords.md:10: To dry run through the ...
5 years, 7 months ago (2015-04-28 17:15:19 UTC) #3
rmistry
https://codereview.chromium.org/1107343004/diff/1/site/dev/contrib/cqkeywords.md File site/dev/contrib/cqkeywords.md (right): https://codereview.chromium.org/1107343004/diff/1/site/dev/contrib/cqkeywords.md#newcode10 site/dev/contrib/cqkeywords.md:10: To dry run through the CQ please use Rietveld's ...
5 years, 7 months ago (2015-04-28 17:27:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107343004/20001
5 years, 7 months ago (2015-04-28 17:28:05 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 17:28:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/38620209ca67535686c6b62a2185254ef119196a

Powered by Google App Engine
This is Rietveld 408576698