Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1107293002: CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (2) (Closed)

Created:
5 years, 8 months ago by nhiroki
Modified:
5 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_cache_listener_and_dispatcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (2) CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship and the indirection is no longer necessary. This CL moves the rest of the stuff to the dispatcher, and removes the listener. 1st CL: https://codereview.chromium.org/1111713002/ BUG=474233 TEST=content_unittests --gtest_filter=CacheStorage* TEST=run-webkit-tests http/tests/cachestorage/ Committed: https://crrev.com/31aad3b6880b794f916cdd4f1a846a878675080f Cr-Commit-Position: refs/heads/master@{#327303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -444 lines) Patch
M content/browser/cache_storage/cache_storage_dispatcher_host.h View 4 chunks +72 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 6 chunks +236 lines, -9 lines 0 comments Download
D content/browser/cache_storage/cache_storage_listener.h View 1 chunk +0 lines, -121 lines 0 comments Download
D content/browser/cache_storage/cache_storage_listener.cc View 1 chunk +0 lines, -305 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nhiroki
PTAL, thanks!
5 years, 7 months ago (2015-04-28 08:43:12 UTC) #4
jsbell
lgtm!
5 years, 7 months ago (2015-04-28 16:02:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107293002/40001
5 years, 7 months ago (2015-04-28 16:03:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 7 months ago (2015-04-28 16:51:00 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:51:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31aad3b6880b794f916cdd4f1a846a878675080f
Cr-Commit-Position: refs/heads/master@{#327303}

Powered by Google App Engine
This is Rietveld 408576698