Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1107283005: Disable ThreadWatcher in STABLE channel temporarily to measure its (Closed)

Created:
5 years, 7 months ago by ramant (doing other things)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@thread_watcher_stable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ThreadWatcher in STABLE channel temporarily to measure its impact on battery. Will be measuring its impact in the following dashboard. https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac9&tests=power.top_25%2Fidle_wakeups_total&checked=idle_wakeups_total%2Cref R=asvitkine@chromium.org BUG=426203 Committed: https://crrev.com/61267c2bf9596756e10e12176d684e987a9ddb2d Cr-Commit-Position: refs/heads/master@{#327555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/metrics/thread_watcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ramant (doing other things)
5 years, 7 months ago (2015-04-29 19:18:41 UTC) #1
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-04-29 19:19:02 UTC) #2
Andre
Why not simply disable on all channels? It's temporary and won't ship to those channels ...
5 years, 7 months ago (2015-04-29 19:19:25 UTC) #4
ramant (doing other things)
On 2015/04/29 19:19:25, Andre wrote: > Why not simply disable on all channels? > It's ...
5 years, 7 months ago (2015-04-29 19:22:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107283005/1
5 years, 7 months ago (2015-04-29 19:24:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:26:51 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:28:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61267c2bf9596756e10e12176d684e987a9ddb2d
Cr-Commit-Position: refs/heads/master@{#327555}

Powered by Google App Engine
This is Rietveld 408576698