Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1107283003: Remove system call in DW for default font. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove system call in DW for default font. The last user of the GDI default font in DW is onMatchFamilyStyleCharacter and it doesn't appear to actually need to use it. This change removes a system call, making things a bit faster, as well as eliminating a call blocked in the sandbox. BUG=chromium:459056 Committed: https://skia.googlesource.com/skia/+/c64239a466b6e083ada93c2842d9e48bae606dfe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M gm/fontmgr.cpp View 2 chunks +6 lines, -6 lines 1 comment Download
M src/ports/SkFontMgr_win_dw.cpp View 3 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
See associated bug, but it turns out that win32k lockdown means that the call to ...
5 years, 7 months ago (2015-04-29 15:05:40 UTC) #2
reed1
lgtm
5 years, 7 months ago (2015-04-29 15:11:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107283003/1
5 years, 7 months ago (2015-04-29 15:12:38 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:15:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c64239a466b6e083ada93c2842d9e48bae606dfe

Powered by Google App Engine
This is Rietveld 408576698