Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: chrome/app/generated_resources.grd

Issue 1107273002: Use the new ICU plural syntax to fix the strings in the hung pages dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: grd descriptions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/app/nibs/HungRendererDialog.xib » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 8922cecb0fc93ddbf834bc58420b6ca4e375bd94..591fe1f2b2d8d901e97b903b3d4b62c33769b4f7 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7571,17 +7571,21 @@ Keep your key file in a safe place. You will need it to create new versions of y
</ex></ph>Would you like to stop it?
</message>
</if>
- <message name="IDS_BROWSER_HANGMONITOR_RENDERER_TITLE" desc="The title of the 'A renderer has hung' dialog">
- Page(s) Unresponsive
+ <message name="IDS_BROWSER_HANGMONITOR_RENDERER_TITLE" desc="The title of the 'A renderer has hung' dialog. NOTE: If having no explicit # makes the phrasing awkward, feel free to add a # as necessary. [ICU Syntax]">
+ {NUM_PAGES, plural,
+ =1 {Page Unresponsive}
+ other {Pages Unresponsive}}
</message>
- <message name="IDS_BROWSER_HANGMONITOR_RENDERER" desc="A renderer has hung">
- The following page(s) have become unresponsive. You can wait for them to become responsive or kill them.
+ <message name="IDS_BROWSER_HANGMONITOR_RENDERER" desc="A renderer has hung. NOTE: If having no explicit # makes the phrasing awkward, feel free to add a # as necessary. [ICU Syntax]">
+ {NUM_PAGES, plural,
+ =1 {The following page has become unresponsive. You can wait for it to become responsive or kill it.}
+ other {The following pages have become unresponsive. You can wait for them to become responsive or kill them.}}
</message>
<message name="IDS_BROWSER_HANGMONITOR_RENDERER_WAIT" desc="The label of the 'wait' button">
Wait
</message>
<message name="IDS_BROWSER_HANGMONITOR_RENDERER_END" desc="The label of the 'kill' button">
- Kill pages
+ Kill
</message>
<message name="IDS_BROWSER_HANGMONITOR_PLUGIN_INFOBAR" desc="The text of the infobar notifying the user that a plugin has hung">
A plugin (<ph name="PLUGIN_NAME">$1<ex>Flash</ex></ph>) isn't responding.
« no previous file with comments | « no previous file | chrome/app/nibs/HungRendererDialog.xib » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698