Source/devtools/front_end/components/ObjectPopoverHelper.js - Issue 1107233003: Devtools: [CustomFormatter] Add context menu to disassemble custom previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 1107233003: Devtools: [CustomFormatter] Add context menu to disassemble custom previews (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/components/CustomPreviewSection.js ('K') | « Source/devtools/front_end/components/CustomPreviewSection.js ('k') | Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/ObjectPopoverHelper.js

diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js

index 3455c86bd8cc7908b381712f3299660f7e22f795..eaac5b3acd6a39ff7e24166209e74a7ef0e61c01 100644

--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js

+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js

@@ -163,7 +163,9 @@ WebInspector.ObjectPopoverHelper.prototype = {

}

if (result.customPreview()) {

- popoverContentElement = WebInspector.CustomPreviewSection.createInShadow(result, true);

+ var customPreviewComponent = new WebInspector.CustomPreviewComponent(result);

+ customPreviewComponent.expandIfPossible();

+ popoverContentElement = customPreviewComponent.element;

} else {

popoverContentElement = createElement("div");

this._titleElement = popoverContentElement.createChild("div", "monospace");