Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1107223002: [Extensions] Precede api enums with an '_' if the first character is a digit (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, stevenjb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Precede api enums with an '_' if the first character is a digit If the first character of an extension api enum is a digit (we know that the enums can only be composed of a-zA-Z0-9_ now), then precede it with a digit so that people can do chrome.fooApi._345_CRAZY_ENUM. BUG=463184 Committed: https://crrev.com/bba416f4bad7fccd508a09a21dc23c503e28cdca Cr-Commit-Position: refs/heads/master@{#327198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M extensions/renderer/resources/binding.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Devlin
We don't (yet) have any enums quite this crazy, so no test added, but I ...
5 years, 8 months ago (2015-04-27 23:03:19 UTC) #2
not at google - send to devlin
lgtm. remember we need to document this stuff.
5 years, 8 months ago (2015-04-27 23:05:02 UTC) #3
Devlin
On 2015/04/27 23:05:02, kalman wrote: > lgtm. remember we need to document this stuff. Yep. ...
5 years, 8 months ago (2015-04-27 23:05:58 UTC) #4
Devlin
+Steven as FYI.
5 years, 8 months ago (2015-04-27 23:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107223002/1
5 years, 8 months ago (2015-04-27 23:07:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 00:50:09 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 00:50:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bba416f4bad7fccd508a09a21dc23c503e28cdca
Cr-Commit-Position: refs/heads/master@{#327198}

Powered by Google App Engine
This is Rietveld 408576698