Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1107203003: Update sky/sdk/README.md instructions (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
Matt Perry, Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -12 lines) Patch
M sky/sdk/README.md View 4 chunks +56 lines, -12 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
eseidel
5 years, 8 months ago (2015-04-27 21:26:14 UTC) #1
Hixie
lgtm
5 years, 8 months ago (2015-04-27 21:28:34 UTC) #2
eseidel
Committed patchset #1 (id:1) manually as 18027b7d1e9a8a40979879f757d22fcda1fb73a8 (presubmit successful).
5 years, 8 months ago (2015-04-27 21:28:49 UTC) #3
Matt Perry
https://codereview.chromium.org/1107203003/diff/1/sky/sdk/README.md File sky/sdk/README.md (right): https://codereview.chromium.org/1107203003/diff/1/sky/sdk/README.md#newcode136 sky/sdk/README.md:136: 1. ``packages/sky/lib/sky_tool --install examples/stocks/main.sky`` This didn't work for me. ...
5 years, 8 months ago (2015-04-27 21:32:27 UTC) #5
eseidel
5 years, 8 months ago (2015-04-27 21:34:55 UTC) #6
Message was sent while issue was closed.
Correct.  I'm about to fix that.  The problem is that my instructions assume
you're using the dart_summit branch of sky_sdk.  I'm going to delete the
dart_summit branch of sky_sdk and just make mainline be the correct one, despite
it having been created from a branch of mojo.

Powered by Google App Engine
This is Rietveld 408576698