Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1107203002: [es6] Fix return checking in derived constructors (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix return checking in derived constructors In a derived class constructor in case undefined is returned, we should return the receiver. If the return is any other value type we should throw a TypeError. BUG=v8:4061 LOG=N R=dslomov@chromium.org, adamk@chromium.org Committed: https://crrev.com/baddc25eb2fa797649f92ba4a8fa7603ce38d49a Cr-Commit-Position: refs/heads/master@{#28114}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Fix issue where the temp var was not declared in the right scope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/classes-derived-return-type.js View 1 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
arv (Not doing code reviews)
cleanup
5 years, 8 months ago (2015-04-27 21:29:41 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 8 months ago (2015-04-27 21:29:54 UTC) #2
adamk
Code lgtm, but it looks like you might have a real test failure.
5 years, 8 months ago (2015-04-27 22:04:03 UTC) #3
arv (Not doing code reviews)
Fix issue where the temp var was not declared in the right scope
5 years, 7 months ago (2015-04-28 15:14:19 UTC) #4
arv (Not doing code reviews)
Debug assert fixed. Dmitry, can you take a look too?
5 years, 7 months ago (2015-04-28 15:15:04 UTC) #5
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-04-28 16:05:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107203002/40001
5 years, 7 months ago (2015-04-28 16:08:02 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 16:09:27 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:09:40 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/baddc25eb2fa797649f92ba4a8fa7603ce38d49a
Cr-Commit-Position: refs/heads/master@{#28114}

Powered by Google App Engine
This is Rietveld 408576698