[Telemetry][Android] Get voltage from device for dumpsys power monitor

[Telemetry][Android] Get voltage from device for dumpsys power monitor

Currently the dumpsys power monitor uses a static value of 4.0 for the voltage
when determining the power usage. This changes it to get the voltage from the
device to make the power measurements more accurate.

BUG=476043
Committed: https://crrev.com/3627362950fd56f0a00572af62b3999f2ea4f8e3
Cr-Commit-Position: refs/heads/master@{#327177}

[rnephew (Reviews Here), 2015-04-27 19:20:49]

rnephew@chromium.org changed reviewers:
+ baxley@chromium.org, nednguyen@google.com, sullivan@chromium.org

[sullivan, 2015-04-27 19:41:20]

lgtm

https://codereview.chromium.org/1107173002/diff/1/tools/telemetry/telemetry/c...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://codereview.chromium.org/1107173002/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:59:
logging.warning('Unable to get device voltage. Using 4.0.')
Might want to copy/modify the comment from the old code:

# Converting at a nominal voltage of 4.0V, as those values are obtained by a	
# heuristic, and 4.0V is the voltage we set when using a monsoon device.

[rnephew (Reviews Here), 2015-04-27 19:56:56]

https://codereview.chromium.org/1107173002/diff/1/tools/telemetry/telemetry/c...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://codereview.chromium.org/1107173002/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:59:
logging.warning('Unable to get device voltage. Using 4.0.')
On 2015/04/27 19:41:20, sullivan wrote:
> Might want to copy/modify the comment from the old code:
> 
> # Converting at a nominal voltage of 4.0V, as those values are obtained by a	
> # heuristic, and 4.0V is the voltage we set when using a monsoon device.

Done.

[rnephew (Reviews Here), 2015-04-27 19:56:59]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2015-04-27 19:56:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/1107173002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-04-27 19:58:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107173002/20001

[nednguyen, 2015-04-27 20:30:37]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-04-27 20:34:45]

https://codereview.chromium.org/1107173002/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://codereview.chromium.org/1107173002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:58:
except TypeError:
Instead of catch the TypeError when converting from None to float, please make
an if-else statement to make the code more readable.

voltage = battery_info.get('voltage')
if voltage is None:
   ...
else:
   ...

[rnephew (Reviews Here), 2015-04-27 21:01:26]

https://codereview.chromium.org/1107173002/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
(right):

https://codereview.chromium.org/1107173002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:58:
except TypeError:
On 2015/04/27 20:34:45, nednguyen wrote:
> Instead of catch the TypeError when converting from None to float, please make
> an if-else statement to make the code more readable.
> 
> voltage = battery_info.get('voltage')
> if voltage is None:
>    ...
> else:
>    ...

Done.

[nednguyen, 2015-04-27 21:08:30]

Thanks

lgtm

[rnephew (Reviews Here), 2015-04-27 21:09:08]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2015-04-27 21:09:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/1107173002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-27 21:10:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107173002/40001

[commit-bot: I haz the power, 2015-04-27 23:47:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-27 23:48:03]

Patchset 3 (id:??) landed as
https://crrev.com/3627362950fd56f0a00572af62b3999f2ea4f8e3
Cr-Commit-Position: refs/heads/master@{#327177}