Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: base/trace_event/winheap_dump_provider_win.h

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/winheap_dump_provider_win.h
diff --git a/base/trace_event/winheap_dump_provider_win.h b/base/trace_event/winheap_dump_provider_win.h
index 8abac47efce08bd44b3101632b8ef03faa47a67c..42f489d17c2c1a79656a8d68e47af4280c528741 100644
--- a/base/trace_event/winheap_dump_provider_win.h
+++ b/base/trace_event/winheap_dump_provider_win.h
@@ -29,8 +29,7 @@ class BASE_EXPORT WinHeapDumpProvider : public MemoryDumpProvider {
static WinHeapDumpProvider* GetInstance();
// MemoryDumpProvider implementation.
- bool DumpInto(ProcessMemoryDump* pmd) override;
- const char* GetFriendlyName() const override;
+ bool OnMemoryDump(ProcessMemoryDump* pmd) override;
private:
friend struct DefaultSingletonTraits<WinHeapDumpProvider>;
@@ -42,7 +41,7 @@ class BASE_EXPORT WinHeapDumpProvider : public MemoryDumpProvider {
const std::set<void*>& block_to_skip);
WinHeapDumpProvider() {}
- ~WinHeapDumpProvider() override {}
+ virtual ~WinHeapDumpProvider() {}
DISALLOW_COPY_AND_ASSIGN(WinHeapDumpProvider);
};

Powered by Google App Engine
This is Rietveld 408576698