base/trace_event/process_memory_maps_dump_provider.h - Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_maps_dump_provider.h

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/process_memory_maps_dump_provider.h

diff --git a/base/trace_event/process_memory_maps_dump_provider.h b/base/trace_event/process_memory_maps_dump_provider.h

index 0d30db2019f97db53883284e0f0b6cba75d0dba7..230edf1daef8059473eafe99b357fa195926e1ad 100644

--- a/base/trace_event/process_memory_maps_dump_provider.h

+++ b/base/trace_event/process_memory_maps_dump_provider.h

@@ -20,8 +20,7 @@ class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {

static ProcessMemoryMapsDumpProvider* GetInstance();

// MemoryDumpProvider implementation.

- bool DumpInto(ProcessMemoryDump* pmd) override;

- const char* GetFriendlyName() const override;

+ bool OnMemoryDump(ProcessMemoryDump* pmd) override;

private:

friend struct DefaultSingletonTraits<ProcessMemoryMapsDumpProvider>;

@@ -32,7 +31,7 @@ class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {

#endif

ProcessMemoryMapsDumpProvider();

- ~ProcessMemoryMapsDumpProvider() override;

+ virtual ~ProcessMemoryMapsDumpProvider();

DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMapsDumpProvider);

};