Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: base/trace_event/java_heap_dump_provider_android.h

Issue 1107093004: [tracing] Simplify MemoryDumpProvider interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/java_heap_dump_provider_android.h
diff --git a/base/trace_event/java_heap_dump_provider_android.h b/base/trace_event/java_heap_dump_provider_android.h
index 82807510b2a463d799b183400127b8c94ded1c27..3be64698c75753fdbff349a7cfb9d2c69c9b268b 100644
--- a/base/trace_event/java_heap_dump_provider_android.h
+++ b/base/trace_event/java_heap_dump_provider_android.h
@@ -17,14 +17,13 @@ class JavaHeapDumpProvider : public MemoryDumpProvider {
static JavaHeapDumpProvider* GetInstance();
// MemoryDumpProvider implementation.
- bool DumpInto(ProcessMemoryDump* pmd) override;
- const char* GetFriendlyName() const override;
+ bool OnMemoryDump(ProcessMemoryDump* pmd) override;
private:
friend struct DefaultSingletonTraits<JavaHeapDumpProvider>;
JavaHeapDumpProvider();
- ~JavaHeapDumpProvider() override;
+ virtual ~JavaHeapDumpProvider();
DISALLOW_COPY_AND_ASSIGN(JavaHeapDumpProvider);
};

Powered by Google App Engine
This is Rietveld 408576698