[tracing] Simplify MemoryDumpProvider interface

base/trace_event/winheap_dump_provider_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/winheap_dump_provider_win.h"
 
 #include <windows.h>
 
 #include "base/trace_event/process_memory_dump.h"
 
@@ skipping 20 matching lines @@
   return true;
 }
 
 }  // namespace
 
 WinHeapDumpProvider* WinHeapDumpProvider::GetInstance() {
   return Singleton<WinHeapDumpProvider,
                    LeakySingletonTraits<WinHeapDumpProvider>>::get();
 }
 
-bool WinHeapDumpProvider::DumpInto(ProcessMemoryDump* pmd) {
+bool WinHeapDumpProvider::OnMemoryDump(ProcessMemoryDump* pmd) {
   // Retrieves the number of heaps in the current process.
   DWORD number_of_heaps = ::GetProcessHeaps(0, NULL);
   WinHeapInfo all_heap_info = {0};
 
   // Try to retrieve a handle to all the heaps owned by this process. Returns
   // false if the number of heaps has changed.
   //
   // This is inherently racy as is, but it's not something that we observe a lot
   // in Chrome, the heaps tend to be created at startup only.
   scoped_ptr<HANDLE[]> all_heaps(new HANDLE[number_of_heaps]);
@@ skipping 15 matching lines @@
     all_heap_info.committed_size += heap_info.committed_size;
     all_heap_info.block_count += heap_info.block_count;
   }
   // Report the heap dump.
   if (!ReportHeapDump(pmd, all_heap_info, MemoryAllocatorDump::kRootHeap))
     return false;
 
   return true;
 }
 
-const char* WinHeapDumpProvider::GetFriendlyName() const {
-  return kDumperFriendlyName;
-}
-
 bool WinHeapDumpProvider::GetHeapInformation(
     WinHeapInfo* heap_info,
     const std::set<void*>& block_to_skip) {
   CHECK(::HeapLock(heap_info->heap_id) == TRUE);
   PROCESS_HEAP_ENTRY heap_entry;
   heap_entry.lpData = nullptr;
   // Walk over all the entries in this heap.
   while (::HeapWalk(heap_info->heap_id, &heap_entry) != FALSE) {
     if (block_to_skip.count(heap_entry.lpData) == 1)
       continue;
     if ((heap_entry.wFlags & PROCESS_HEAP_ENTRY_BUSY) != 0) {
       heap_info->allocated_size += heap_entry.cbData;
       heap_info->block_count++;
     } else if ((heap_entry.wFlags & PROCESS_HEAP_REGION) != 0) {
       heap_info->committed_size += heap_entry.Region.dwCommittedSize;
     }
   }
   CHECK(::HeapUnlock(heap_info->heap_id) == TRUE);
   return true;
 }
 
 }  // namespace trace_event
 }  // namespace base