Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1107083002: Upstream more leaf files in ios/web/web_state (Closed)

Created:
5 years, 8 months ago by stuartmorgan
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@web-resync
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream more leaf files in ios/web/web_state Also updates a few related files that had become stale relative to downstream. BUG=464810 Committed: https://crrev.com/cd59886d6db2f94ef288bd2f7286021fc221ce44 Cr-Commit-Position: refs/heads/master@{#327081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -56 lines) Patch
M ios/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 2 chunks +10 lines, -0 lines 0 comments Download
A ios/web/public/web_state/credential.h View 1 chunk +47 lines, -0 lines 0 comments Download
M ios/web/public/web_state/crw_web_controller_observer.h View 3 chunks +2 lines, -34 lines 0 comments Download
M ios/web/public/web_state/crw_web_view_scroll_view_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 3 chunks +55 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 2 chunks +8 lines, -0 lines 0 comments Download
A + ios/web/web_state/credential.cc View 1 chunk +6 lines, -4 lines 0 comments Download
A ios/web/web_state/js/credential_util.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/web/web_state/js/credential_util.mm View 1 chunk +100 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager.mm View 2 chunks +2 lines, -12 lines 0 comments Download
A ios/web/web_state/js/crw_js_invoke_parameter_queue.h View 1 chunk +65 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_invoke_parameter_queue.mm View 1 chunk +99 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_plugin_placeholder_manager.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm View 1 chunk +51 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_window_id_manager.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/web/web_state/js/crw_js_window_id_manager.mm View 1 chunk +73 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/core.js View 1 chunk +8 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stuartmorgan
eugenebut for review rsleevi for the crypto DEPS entry (for random byte generation)
5 years, 8 months ago (2015-04-27 17:00:51 UTC) #2
Ryan Sleevi
DEPS LGTM
5 years, 8 months ago (2015-04-27 17:07:31 UTC) #3
Eugene But (OOO till 7-30)
lgtm
5 years, 8 months ago (2015-04-27 17:27:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107083002/1
5 years, 8 months ago (2015-04-27 18:13:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 18:35:27 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:36:19 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cd59886d6db2f94ef288bd2f7286021fc221ce44
Cr-Commit-Position: refs/heads/master@{#327081}

Powered by Google App Engine
This is Rietveld 408576698