content/child/resource_dispatcher.cc - Issue 1107043003: [ABANDONED] Make sure that threaded-data-provider doesn't cause a use-after-free.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/resource_dispatcher.cc

Issue 1107043003: [ABANDONED] Make sure that threaded-data-provider doesn't cause a use-after-free. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/resource_dispatcher.cc

diff --git a/content/child/resource_dispatcher.cc b/content/child/resource_dispatcher.cc

index cf56a77c8a0556d01b64afb1d40e1bbba3732faa..69bc04b87d679331912685a0496dc8b841621a45 100644

--- a/content/child/resource_dispatcher.cc

+++ b/content/child/resource_dispatcher.cc

@@ -253,6 +253,7 @@ void ResourceDispatcher::OnReceivedData(int request_id,

if (!request_info->blocked_response || !alternative_data.empty()) {

if (request_info->threaded_data_provider) {

+ DCHECK(alternative_data.empty());

request_info->threaded_data_provider->OnReceivedDataOnForegroundThread(

data_ptr, data_length, encoded_data_length);

// A threaded data provider will take care of its own ACKing, as the

« no previous file with comments | « no previous file | no next file » | no next file with comments »