Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: device/serial/serial_service_impl.h

Issue 1107013002: [device] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Review Comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 5 #ifndef DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
6 #define DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 6 #define DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/message_loop/message_loop_proxy.h" 9 #include "base/message_loop/message_loop_proxy.h"
10 #include "base/single_thread_task_runner.h"
11 #include "base/thread_task_runner_handle.h"
10 #include "device/serial/data_stream.mojom.h" 12 #include "device/serial/data_stream.mojom.h"
11 #include "device/serial/serial.mojom.h" 13 #include "device/serial/serial.mojom.h"
12 #include "device/serial/serial_connection_factory.h" 14 #include "device/serial/serial_connection_factory.h"
13 #include "device/serial/serial_device_enumerator.h" 15 #include "device/serial/serial_device_enumerator.h"
14 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h" 16 #include "third_party/mojo/src/mojo/public/cpp/bindings/interface_impl.h"
15 17
16 namespace device { 18 namespace device {
17 19
18 class SerialServiceImpl : public mojo::InterfaceImpl<serial::SerialService> { 20 class SerialServiceImpl : public mojo::InterfaceImpl<serial::SerialService> {
19 public: 21 public:
20 explicit SerialServiceImpl( 22 explicit SerialServiceImpl(
21 scoped_refptr<SerialConnectionFactory> connection_factory); 23 scoped_refptr<SerialConnectionFactory> connection_factory);
22 SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory, 24 SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory,
23 scoped_ptr<SerialDeviceEnumerator> device_enumerator); 25 scoped_ptr<SerialDeviceEnumerator> device_enumerator);
24 ~SerialServiceImpl() override; 26 ~SerialServiceImpl() override;
25 27
26 static void Create(scoped_refptr<base::MessageLoopProxy> io_message_loop, 28 static void Create(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
27 scoped_refptr<base::MessageLoopProxy> ui_message_loop, 29 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
28 mojo::InterfaceRequest<serial::SerialService> request); 30 mojo::InterfaceRequest<serial::SerialService> request);
29 static void CreateOnMessageLoop( 31 static void CreateOnMessageLoop(
30 scoped_refptr<base::MessageLoopProxy> message_loop, 32 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
31 scoped_refptr<base::MessageLoopProxy> io_message_loop, 33 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
32 scoped_refptr<base::MessageLoopProxy> ui_message_loop, 34 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
33 mojo::InterfaceRequest<serial::SerialService> request); 35 mojo::InterfaceRequest<serial::SerialService> request);
34 36
35 // mojo::InterfaceImpl<SerialService> overrides. 37 // mojo::InterfaceImpl<SerialService> overrides.
36 void GetDevices( 38 void GetDevices(
37 const mojo::Callback<void(mojo::Array<serial::DeviceInfoPtr>)>& callback) 39 const mojo::Callback<void(mojo::Array<serial::DeviceInfoPtr>)>& callback)
38 override; 40 override;
39 void Connect( 41 void Connect(
40 const mojo::String& path, 42 const mojo::String& path,
41 serial::ConnectionOptionsPtr options, 43 serial::ConnectionOptionsPtr options,
42 mojo::InterfaceRequest<serial::Connection> connection_request, 44 mojo::InterfaceRequest<serial::Connection> connection_request,
43 mojo::InterfaceRequest<serial::DataSink> sink, 45 mojo::InterfaceRequest<serial::DataSink> sink,
44 mojo::InterfaceRequest<serial::DataSource> source, 46 mojo::InterfaceRequest<serial::DataSource> source,
45 mojo::InterfacePtr<serial::DataSourceClient> source_client) override; 47 mojo::InterfacePtr<serial::DataSourceClient> source_client) override;
46 48
47 private: 49 private:
48 SerialDeviceEnumerator* GetDeviceEnumerator(); 50 SerialDeviceEnumerator* GetDeviceEnumerator();
49 bool IsValidPath(const mojo::String& path); 51 bool IsValidPath(const mojo::String& path);
50 52
51 scoped_ptr<SerialDeviceEnumerator> device_enumerator_; 53 scoped_ptr<SerialDeviceEnumerator> device_enumerator_;
52 scoped_refptr<SerialConnectionFactory> connection_factory_; 54 scoped_refptr<SerialConnectionFactory> connection_factory_;
53 55
54 DISALLOW_COPY_AND_ASSIGN(SerialServiceImpl); 56 DISALLOW_COPY_AND_ASSIGN(SerialServiceImpl);
55 }; 57 };
56 58
57 } // namespace device 59 } // namespace device
58 60
59 #endif // DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 61 #endif // DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698