Issue 1107003002: Check the nullable Document::settings() before accessing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1107003002: Check the nullable Document::settings() before accessing. (Closed)

Created:
5 years, 8 months ago by sof

Modified:
5 years, 8 months ago

Reviewers:
Yoav Weiss, Mike West

CC:
blink-reviews, Nate Chapin, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, tyoshino+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Check the nullable Document::settings() before accessing. Add some missing null checks in LinkLoader. R=yoav@yoav.ws BUG=481511 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194515

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -3 lines)			Patch
A	LayoutTests/fast/dom/HTMLLinkElement/link-preload-settings-no-crash.html	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLLinkElement/link-preload-settings-no-crash-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/loader/LinkLoader.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Yoav Weiss

On 2015/04/27 13:15:43, sof wrote: > please take a look. LGTM

5 years, 8 months ago (2015-04-27 13:17:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107003002/1

5 years, 8 months ago (2015-04-27 13:19:23 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-27 14:29:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194515