Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 1107003002: Check the nullable Document::settings() before accessing. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
Yoav Weiss, Mike West
CC:
blink-reviews, Nate Chapin, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check the nullable Document::settings() before accessing. Add some missing null checks in LinkLoader. R=yoav@yoav.ws BUG=481511 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
A LayoutTests/fast/dom/HTMLLinkElement/link-preload-settings-no-crash.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLLinkElement/link-preload-settings-no-crash-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/LinkLoader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-27 13:15:43 UTC) #2
Yoav Weiss
On 2015/04/27 13:15:43, sof wrote: > please take a look. LGTM
5 years, 8 months ago (2015-04-27 13:17:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107003002/1
5 years, 8 months ago (2015-04-27 13:19:23 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:29:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194515

Powered by Google App Engine
This is Rietveld 408576698