Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1106983004: Filter out store/slots buffer entries that point into raw data objects. (Closed)

Created:
5 years, 8 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Filter out store/slots buffer entries that point into raw data objects. This is just a workaround till we found the root cause of the issue, there must be no slots for data object recorded. BUG=chromium:454297 LOG=N Committed: https://crrev.com/341e4ac29d5ef868912c7aa312741e554b50e00a Cr-Commit-Position: refs/heads/master@{#28756}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Patch Set 3 : Rebased and TODO added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M src/heap/mark-compact.cc View 1 2 2 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Igor Sheludko
PTAL
5 years, 8 months ago (2015-04-27 15:46:29 UTC) #3
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1106983004/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1106983004/diff/20001/src/heap/mark-compact.cc#newcode3235 src/heap/mark-compact.cc:3235: // Filter out slots that happens to point ...
5 years, 8 months ago (2015-04-28 06:31:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106983004/40001
5 years, 8 months ago (2015-04-28 07:14:21 UTC) #7
Hannes Payer (out of office)
One more thing, can we have a test for the byte array and string case?
5 years, 8 months ago (2015-04-28 07:15:33 UTC) #8
Hannes Payer (out of office)
And map case?
5 years, 8 months ago (2015-04-28 07:16:07 UTC) #9
Igor Sheludko
We can't construct a test case where we have a slot in the data objects. ...
5 years, 6 months ago (2015-06-02 10:36:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106983004/60001
5 years, 6 months ago (2015-06-02 10:38:07 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-02 11:00:52 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:01:06 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/341e4ac29d5ef868912c7aa312741e554b50e00a
Cr-Commit-Position: refs/heads/master@{#28756}

Powered by Google App Engine
This is Rietveld 408576698