Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1106973004: Cleanup color space resolution for ReferenceFilterBuilder (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Touchup comment. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2815 matching lines...) Expand 10 before | Expand all | Expand 10 after
2826 } 2826 }
2827 2827
2828 FilterOperations DeprecatedPaintLayer::computeFilterOperations(const ComputedSty le& style) 2828 FilterOperations DeprecatedPaintLayer::computeFilterOperations(const ComputedSty le& style)
2829 { 2829 {
2830 const FilterOperations& filters = style.filter(); 2830 const FilterOperations& filters = style.filter();
2831 if (filters.hasReferenceFilter()) { 2831 if (filters.hasReferenceFilter()) {
2832 for (size_t i = 0; i < filters.size(); ++i) { 2832 for (size_t i = 0; i < filters.size(); ++i) {
2833 FilterOperation* filterOperation = filters.operations().at(i).get(); 2833 FilterOperation* filterOperation = filters.operations().at(i).get();
2834 if (filterOperation->type() != FilterOperation::REFERENCE) 2834 if (filterOperation->type() != FilterOperation::REFERENCE)
2835 continue; 2835 continue;
2836 ReferenceFilterOperation* referenceOperation = toReferenceFilterOper ation(filterOperation); 2836 ReferenceFilterOperation& referenceOperation = toReferenceFilterOper ation(*filterOperation);
2837 // FIXME: Cache the ReferenceFilter if it didn't change. 2837 // FIXME: Cache the ReferenceFilter if it didn't change.
2838 RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilte r::create(style.effectiveZoom()); 2838 RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilte r::create(style.effectiveZoom());
2839 referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referen ceFilter.get(), layoutObject(), referenceFilter->sourceGraphic(), 2839 referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referen ceFilter.get(), *layoutObject(), referenceFilter->sourceGraphic(),
2840 referenceOperation)); 2840 referenceOperation));
2841 referenceOperation->setFilter(referenceFilter.release()); 2841 referenceOperation.setFilter(referenceFilter.release());
2842 } 2842 }
2843 } 2843 }
2844 2844
2845 return filters; 2845 return filters;
2846 } 2846 }
2847 2847
2848 void DeprecatedPaintLayer::updateOrRemoveFilterClients() 2848 void DeprecatedPaintLayer::updateOrRemoveFilterClients()
2849 { 2849 {
2850 if (!hasFilter()) { 2850 if (!hasFilter()) {
2851 removeFilterInfoIfNeeded(); 2851 removeFilterInfoIfNeeded();
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
2965 } 2965 }
2966 } 2966 }
2967 2967
2968 void showLayerTree(const blink::LayoutObject* layoutObject) 2968 void showLayerTree(const blink::LayoutObject* layoutObject)
2969 { 2969 {
2970 if (!layoutObject) 2970 if (!layoutObject)
2971 return; 2971 return;
2972 showLayerTree(layoutObject->enclosingLayer()); 2972 showLayerTree(layoutObject->enclosingLayer());
2973 } 2973 }
2974 #endif 2974 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | Source/core/paint/FilterEffectBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698