|
|
Created:
5 years, 8 months ago by Nikita (slow) Modified:
5 years, 8 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Flip extension background page throttling on by default (patchset #2 id:20001 of https://codereview.chromium.org/1106653002/)
Reason for revert:
Speculative revert - multiple browser_tests fail on Mac10.9 Tests (dbg)
http://goo.gl/4AqhVG
Original issue's description:
> Flip extension background page throttling on by default
>
> R=kalman
> BUG=424661
>
> Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd
> Cr-Commit-Position: refs/heads/master@{#326953}
TBR=kalman@chromium.org,oysteine@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=424661
Committed: https://crrev.com/76a7e3446188256ca240dc31cd5287ef78de2951
Cr-Commit-Position: refs/heads/master@{#327021}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (0 generated)
Created Revert of Flip extension background page throttling on by default
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106953002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/76a7e3446188256ca240dc31cd5287ef78de2951 Cr-Commit-Position: refs/heads/master@{#327021}
Message was sent while issue was closed.
Helped, build is green: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests%... Tests that were failing prior to that: GcmApiTest.SendValidation HotwordPrivateApiTest.SetEnabled HotwordPrivateApiTest.SpeakerModelExistsResult ProxySettingsApiTest.ProxyPacScript and so on
Message was sent while issue was closed.
[1177:1287:0427/030623:INFO:CONSOLE(0)] "[SUCCESS] successWhenHappyPath", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030654:INFO:CONSOLE(0)] "[SUCCESS] successWhenTtlIsZero", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030654:INFO:CONSOLE(0)] "[SUCCESS] successWhenTtlIsMissing", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030656:INFO:CONSOLE(0)] "[SUCCESS] failureWhenTtlIsNegative", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030656:INFO:CONSOLE(0)] "[SUCCESS] failureWhenTtlIsTooLarge", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030658:INFO:CONSOLE(0)] "[SUCCESS] failureWhenMessageIdMissing", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030659:INFO:CONSOLE(0)] "[SUCCESS] failureWhenMessageIdIsEmpty", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030700:INFO:CONSOLE(0)] "[SUCCESS] failureWhenDestinationIdMissing", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030700:INFO:CONSOLE(0)] "[SUCCESS] failureWhenDestinationIdIsEmpty", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030702:INFO:CONSOLE(0)] "[SUCCESS] failureWhenDataIsMissing", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030702:INFO:CONSOLE(0)] "[SUCCESS] failureWhenDataIsEmpty", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030704:INFO:CONSOLE(0)] "[SUCCESS] failureWhenDataKeyIsEmpty", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) BrowserTestBase signal handler received SIGTERM. Backtrace: 0 libbase.dylib 0x000000011c4d9a6f base::debug::StackTrace::StackTrace() + 47 1 libbase.dylib 0x000000011c4d9ac3 base::debug::StackTrace::StackTrace() + 35 2 browser_tests 0x000000010c536b0a content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 74 3 libsystem_platform.dylib 0x00007fff913265aa _sigtramp + 26 4 ??? 0x00007fff0970ec88 0x0 + 140733351783560 5 CoreFoundation 0x00007fff92a5af15 __CFRunLoopServiceMachPort + 181 6 CoreFoundation 0x00007fff92a5a539 __CFRunLoopRun + 1161 7 CoreFoundation 0x00007fff92a59e75 CFRunLoopRunSpecific + 309 8 HIToolbox 0x00007fff95e5fa0d RunCurrentEventLoopInMode + 226 9 HIToolbox 0x00007fff95e5f7b7 ReceiveNextEventCommon + 479 10 HIToolbox 0x00007fff95e5f5bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 11 AppKit 0x00007fff8a55624e _DPSNextEvent + 1434 12 AppKit 0x00007fff8a55589b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 13 AppKit 0x00007fff8a54999c -[NSApplication run] + 553 14 libbase.dylib 0x000000011c4aa2ef base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 335 15 libbase.dylib 0x000000011c4a8fad base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 125 16 libbase.dylib 0x000000011c570d53 base::MessageLoop::RunHandler() + 243 17 libbase.dylib 0x000000011c5e3075 base::RunLoop::Run() + 85 18 browser_tests 0x000000010c611144 content::RunThisRunLoop(base::RunLoop*) + 100 19 browser_tests 0x000000010c6110b8 content::RunMessageLoop() + 40 20 browser_tests 0x000000010c8c533a extensions::ResultCatcher::GetNextResult() + 90 21 browser_tests 0x0000000107318501 ExtensionApiTest::RunExtensionTestImpl(std::string const&, std::string const&, char const*, int) + 1697 22 browser_tests 0x0000000107317e27 ExtensionApiTest::RunExtensionTest(std::string const&) + 87 23 browser_tests 0x000000010679b65f extensions::GcmApiTest_SendValidation_Test::RunTestOnMainThread() + 79 24 browser_tests 0x000000010679b78d non-virtual thunk to extensions::GcmApiTest_SendValidation_Test::RunTestOnMainThread() + 45 25 browser_tests 0x0000000108b9a020 InProcessBrowserTest::RunTestOnMainThreadLoop() + 640 26 browser_tests 0x000000010c536878 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 360 27 browser_tests 0x000000010c5384b7 base::internal::RunnableAdapter\u003Cvoid (content::BrowserTestBase::*)()>::Run(content::BrowserTestBase*) + 119 28 browser_tests 0x000000010c538387 base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (content::BrowserTestBase::*)()>, base::internal::TypeList\u003Ccontent::BrowserTestBase* const&> >::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (content::BrowserTestBase::*)()>, content::BrowserTestBase* const&) + 55 29 browser_tests 0x000000010c53832e base::internal::Invoker\u003CIndexSequence\u003C0ul>, base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (content::BrowserTestBase::*)()>, void (content::BrowserTestBase*), base::internal::TypeList\u003Ccontent::BrowserTestBase*> >, base::internal::TypeList\u003Cbase::internal::UnwrapTraits\u003Ccontent::BrowserTestBase*> >, base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (content::BrowserTestBase::*)()>, base::internal::TypeList\u003Ccontent::BrowserTestBase* const&> >, void ()>::Run(base::internal::BindStateBase*) + 94 30 browser_tests 0x00000001062a064f base::Callback\u003Cvoid ()>::Run() const + 63 31 browser_tests 0x00000001076862e9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 5529 32 browser_tests 0x0000000107684c8a ChromeBrowserMainParts::PreMainMessageLoopRun() + 330 33 libcontent.dylib 0x00000001207add12 content::BrowserMainLoop::PreMainMessageLoopRun() + 370 34 libcontent.dylib 0x00000001207bb967 base::internal::RunnableAdapter\u003Cint (content::BrowserMainLoop::*)()>::Run(content::BrowserMainLoop*) + 119 35 libcontent.dylib 0x00000001207bb8ca base::internal::InvokeHelper\u003Cfalse, int, base::internal::RunnableAdapter\u003Cint (content::BrowserMainLoop::*)()>, base::internal::TypeList\u003Ccontent::BrowserMainLoop*> >::MakeItSo(base::internal::RunnableAdapter\u003Cint (content::BrowserMainLoop::*)()>, content::BrowserMainLoop*) + 58 36 libcontent.dylib 0x00000001207bb866 base::internal::Invoker\u003CIndexSequence\u003C0ul>, base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (content::BrowserMainLoop::*)()>, int (content::BrowserMainLoop*), base::internal::TypeList\u003Cbase::internal::UnretainedWrapper\u003Ccontent::BrowserMainLoop> > >, base::internal::TypeList\u003Cbase::internal::UnwrapTraits\u003Cbase::internal::UnretainedWrapper\u003Ccontent::BrowserMainLoop> > >, base::internal::InvokeHelper\u003Cfalse, int, base::internal::RunnableAdapter\u003Cint (content::BrowserMainLoop::*)()>, base::internal::TypeList\u003Ccontent::BrowserMainLoop*> >, int ()>::Run(base::internal::BindStateBase*) + 102 37 libcontent.dylib 0x0000000120ecdaff base::Callback\u003Cint ()>::Run() const + 63 38 libcontent.dylib 0x00000001213f7aad content::StartupTaskRunner::RunAllTasksNow() + 109 39 libcontent.dylib 0x00000001207abf41 content::BrowserMainLoop::CreateStartupTasks() + 1153 40 libcontent.dylib 0x00000001207becab content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 795 41 libcontent.dylib 0x00000001207a8ddd content::BrowserMain(content::MainFunctionParams const&) + 189 42 libcontent.dylib 0x00000001205c3ae7 content::RunNamedProcessTypeMain(std::string const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 247 43 libcontent.dylib 0x00000001205c4cec content::ContentMainRunnerImpl::Run() + 620 44 libcontent.dylib 0x00000001205c3150 content::ContentMain(content::ContentMainParams const&) + 144 45 browser_tests 0x000000010c5365b2 content::BrowserTestBase::SetUp() + 1202 46 browser_tests 0x0000000108b98b2d InProcessBrowserTest::SetUp() + 1085 47 browser_tests 0x0000000107319d5b ExtensionBrowserTest::SetUp() + 107 48 browser_tests 0x0000000107319dad non-virtual thunk to ExtensionBrowserTest::SetUp() + 45 49 browser_tests 0x0000000108f70718
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1161773008/ by oysteine@chromium.org. The reason for reverting is: Re-landing, tests fixed in https://codereview.chromium.org/1108133002/. |