Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1106953002: Revert of Flip extension background page throttling on by default (Closed)

Created:
5 years, 8 months ago by Nikita (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip extension background page throttling on by default (patchset #2 id:20001 of https://codereview.chromium.org/1106653002/) Reason for revert: Speculative revert - multiple browser_tests fail on Mac10.9 Tests (dbg) http://goo.gl/4AqhVG Original issue's description: > Flip extension background page throttling on by default > > R=kalman > BUG=424661 > > Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd > Cr-Commit-Position: refs/heads/master@{#326953} TBR=kalman@chromium.org,oysteine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=424661 Committed: https://crrev.com/76a7e3446188256ca240dc31cd5287ef78de2951 Cr-Commit-Position: refs/heads/master@{#327021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M extensions/browser/extension_host.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
Created Revert of Flip extension background page throttling on by default
5 years, 8 months ago (2015-04-27 09:45:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106953002/1
5 years, 8 months ago (2015-04-27 09:45:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 09:46:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76a7e3446188256ca240dc31cd5287ef78de2951 Cr-Commit-Position: refs/heads/master@{#327021}
5 years, 8 months ago (2015-04-27 09:47:27 UTC) #4
Nikita (slow)
Helped, build is green: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests%20%28dbg%29&number=5360 Tests that were failing prior to that: GcmApiTest.SendValidation HotwordPrivateApiTest.SetEnabled HotwordPrivateApiTest.SpeakerModelExistsResult ...
5 years, 8 months ago (2015-04-27 11:49:35 UTC) #5
Nikita (slow)
[1177:1287:0427/030623:INFO:CONSOLE(0)] "[SUCCESS] successWhenHappyPath", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030654:INFO:CONSOLE(0)] "[SUCCESS] successWhenTtlIsZero", source: chrome-extension://aokibknnjbafdjgfdjbjgcmgkebjkbkk/_generated_background_page.html (0) [1177:1287:0427/030654:INFO:CONSOLE(0)] "[SUCCESS] successWhenTtlIsMissing", ...
5 years, 8 months ago (2015-04-27 11:50:14 UTC) #6
oystein (OOO til 10th of July)
5 years, 6 months ago (2015-05-29 22:19:54 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1161773008/ by oysteine@chromium.org.

The reason for reverting is: Re-landing, tests fixed in
https://codereview.chromium.org/1108133002/.

Powered by Google App Engine
This is Rietveld 408576698