Revert of Let test_isolation_mode default to check on mac.

Revert of https://codereview.chromium.org/92303002/
Reason for revert: Broke Google Chrome Mac builder

TBR=maruel@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true

[Vadim Sh., 2013-12-19 00:25:10]

Created Revert of Let test_isolation_mode default to check on mac.

[Nico, 2013-12-19 00:26:21]

I reverted this already, see
241705<http://src.chromium.org/viewvc/chrome?view=rev&revision=241705>


On Wed, Dec 18, 2013 at 4:25 PM, <vadimsh@chromium.org> wrote:

> Reviewers: M-A Ruel, Nico,
>
> Message:
> Created Revert of Let test_isolation_mode default to check on mac.
>
> Description:
> Revert of https://codereview.chromium.org/92303002/
> Reason for revert: Broke Google Chrome Mac builder
>
> TBR=maruel@chromium.org,thakis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/110693005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -1 lines):
>   M build/common.gypi
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-19 00:26:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimsh@chromium.org/110693005/1

[commit-bot: I haz the power, 2013-12-19 00:26:54]

Failed to apply patch for build/common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/common.gypi
  Hunk #1 FAILED at 756.
  1 out of 1 hunk FAILED -- saving rejects to file build/common.gypi.rej

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
55d00e1b67c2cdb94ae457f62877137b81106384..97e8596bd021e114af6db6b25e4439b7ddb5c89b
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -756,10 +756,12 @@
         # overriden with GYP_DEFINES.
         # TODO(maruel): Remove the conditions as more configurations are
         # supported.
+        # TODO(csharp): Remove OS!="mac" once xcode can run the isolate code
+        # again.
         # NOTE: The check for disable_nacl==0 and component=="static_library"
         # can't be used here because these variables are not defined yet, but
it
         # is still not supported.
-        ['OS!="ios" and OS!="android" and chromeos==0', {
+        ['OS!="mac" and OS!="ios" and OS!="android" and chromeos==0', {
           'test_isolation_mode%': 'check',
         }, {
           'test_isolation_mode%': 'noop',

[Vadim Sh., 2013-12-19 00:27:30]

Broken build: 
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

[Vadim Sh., 2013-12-19 00:28:00]

On 2013/12/19 00:26:54, I haz the power (commit-bot) wrote:
> Failed to apply patch for build/common.gypi:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file build/common.gypi
>   Hunk #1 FAILED at 756.
>   1 out of 1 hunk FAILED -- saving rejects to file build/common.gypi.rej
> 
> Patch:       build/common.gypi
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
55d00e1b67c2cdb94ae457f62877137b81106384..97e8596bd021e114af6db6b25e4439b7ddb5c89b
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -756,10 +756,12 @@
>          # overriden with GYP_DEFINES.
>          # TODO(maruel): Remove the conditions as more configurations are
>          # supported.
> +        # TODO(csharp): Remove OS!="mac" once xcode can run the isolate code
> +        # again.
>          # NOTE: The check for disable_nacl==0 and component=="static_library"
>          # can't be used here because these variables are not defined yet, but
> it
>          # is still not supported.
> -        ['OS!="ios" and OS!="android" and chromeos==0', {
> +        ['OS!="mac" and OS!="ios" and OS!="android" and chromeos==0', {
>            'test_isolation_mode%': 'check',
>          }, {
>            'test_isolation_mode%': 'noop',

Ok. 

Drover then...

[Nico, 2013-12-19 00:28:06]

(Also, this is a pretty bad revert message that's not very actionable. Mine
is admittedly not much better, but it links to a bug where I pasted
details. Try to write revert commit messages that make it possible for the
author of the CL you're reverting to: a) figure out what exactly went wrong
on which bot b) reland their cl with a reasonable confidence that they
actually fixed the problem)


On Wed, Dec 18, 2013 at 4:25 PM, <vadimsh@chromium.org> wrote:

> Reviewers: M-A Ruel, Nico,
>
> Message:
> Created Revert of Let test_isolation_mode default to check on mac.
>
> Description:
> Revert of https://codereview.chromium.org/92303002/
> Reason for revert: Broke Google Chrome Mac builder
>
> TBR=maruel@chromium.org,thakis@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/110693005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -1 lines):
>   M build/common.gypi
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ncarter (slow), 2013-12-19 00:34:32]

We wouldn't have been confused about this if you'd been available on IRC.


On Wed, Dec 18, 2013 at 4:28 PM, Nico Weber <thakis@chromium.org> wrote:

> (Also, this is a pretty bad revert message that's not very actionable.
> Mine is admittedly not much better, but it links to a bug where I pasted
> details. Try to write revert commit messages that make it possible for the
> author of the CL you're reverting to: a) figure out what exactly went wrong
> on which bot b) reland their cl with a reasonable confidence that they
> actually fixed the problem)
>
>
> On Wed, Dec 18, 2013 at 4:25 PM, <vadimsh@chromium.org> wrote:
>
>> Reviewers: M-A Ruel, Nico,
>>
>> Message:
>> Created Revert of Let test_isolation_mode default to check on mac.
>>
>> Description:
>> Revert of https://codereview.chromium.org/92303002/
>> Reason for revert: Broke Google Chrome Mac builder
>>
>> TBR=maruel@chromium.org,thakis@chromium.org
>> NOTREECHECKS=true
>> NOTRY=true
>>
>> Please review this at https://codereview.chromium.org/110693005/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+3, -1 lines):
>>   M build/common.gypi
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Vadim Sh., 2013-12-19 00:37:40]

On 2013/12/19 00:28:06, Nico wrote:
> (Also, this is a pretty bad revert message that's not very actionable. Mine
> is admittedly not much better, but it links to a bug where I pasted
> details. Try to write revert commit messages that make it possible for the
> author of the CL you're reverting to: a) figure out what exactly went wrong
> on which bot b) reland their cl with a reasonable confidence that they
> actually fixed the problem)
> 
> 

Thanks. I'll try to improve my messaging. In my defense I'd say I posted a link
to a log of broken build in a comment for this CL. Given that 'compile' failed
quite cleanly, I thought it's enough for CL author to figure out what happened.
Your revert message is much more detailed because you worked on that CL and know
what's going on :)

[Nico, 2013-12-19 00:40:10]

On Wed, Dec 18, 2013 at 4:37 PM, <vadimsh@chromium.org> wrote:

> On 2013/12/19 00:28:06, Nico wrote:
>
>> (Also, this is a pretty bad revert message that's not very actionable.
>> Mine
>> is admittedly not much better, but it links to a bug where I pasted
>> details. Try to write revert commit messages that make it possible for the
>> author of the CL you're reverting to: a) figure out what exactly went
>> wrong
>> on which bot b) reland their cl with a reasonable confidence that they
>> actually fixed the problem)
>>
>
>
>
> Thanks. I'll try to improve my messaging. In my defense I'd say I posted a
> link
> to a log of broken build in a comment for this CL. Given that 'compile'
> failed
> quite cleanly,


(It only broke on official, which doesn't have try bots.)


> I thought it's enough for CL author to figure out what happened.
> Your revert message is much more detailed because you worked on that CL
> and know
> what's going on :)
>
>
>
> https://codereview.chromium.org/110693005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-12-19 00:41:03]

On Wed, Dec 18, 2013 at 4:34 PM, Nick Carter <nick@chromium.org> wrote:

> We wouldn't have been confused about this if you'd been available on IRC.
>

Sorry, I was just running to the shuttle. Shuttle wireless was for some
reason broken, so autoreconnect to irc didn't work.


>
>
> On Wed, Dec 18, 2013 at 4:28 PM, Nico Weber <thakis@chromium.org> wrote:
>
>> (Also, this is a pretty bad revert message that's not very actionable.
>> Mine is admittedly not much better, but it links to a bug where I pasted
>> details. Try to write revert commit messages that make it possible for the
>> author of the CL you're reverting to: a) figure out what exactly went wrong
>> on which bot b) reland their cl with a reasonable confidence that they
>> actually fixed the problem)
>>
>>
>> On Wed, Dec 18, 2013 at 4:25 PM, <vadimsh@chromium.org> wrote:
>>
>>> Reviewers: M-A Ruel, Nico,
>>>
>>> Message:
>>> Created Revert of Let test_isolation_mode default to check on mac.
>>>
>>> Description:
>>> Revert of https://codereview.chromium.org/92303002/
>>> Reason for revert: Broke Google Chrome Mac builder
>>>
>>> TBR=maruel@chromium.org,thakis@chromium.org
>>> NOTREECHECKS=true
>>> NOTRY=true
>>>
>>> Please review this at https://codereview.chromium.org/110693005/
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>>
>>> Affected files (+3, -1 lines):
>>>   M build/common.gypi
>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.