Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1106853002: Update lists of compile targets for the GN bots. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
sof, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update lists of compile targets for the GN bots. Previously most of the GN bots were explicitly building "all", which is a lot more than we build on the (non-clobber) GYP bots. This patch syncs the lists so that we build the same targets the GYP bots build as much as possible (in some cases the targets don't work yet for GYP). This also will workaround a bug in MB where building "all" bypasses analyze. R=phajdan.jr@chromium.org BUG=461019, 480643 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg Committed: https://crrev.com/a5319cfb4311320aa80dbc48fdc0b24192262439 Cr-Commit-Position: refs/heads/master@{#326948}

Patch Set 1 #

Patch Set 2 : remove nacl_loader_unttests from dbg bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+861 lines, -20 lines) Patch
M testing/buildbot/chromium.chromiumos.json View 2 chunks +96 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 chunks +101 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +52 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +102 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +106 lines, -2 lines 0 comments Download
M testing/buildbot/client.v8.json View 1 chunk +51 lines, -1 line 0 comments Download
M testing/buildbot/manage.py View 1 chunk +5 lines, -1 line 0 comments Download
M testing/buildbot/tryserver.blink.json View 1 chunk +48 lines, -1 line 0 comments Download
M testing/buildbot/tryserver.chromium.linux.json View 1 4 chunks +197 lines, -4 lines 0 comments Download
M testing/buildbot/tryserver.chromium.mac.json View 2 chunks +52 lines, -2 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +51 lines, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-24 21:49:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106853002/1
5 years, 8 months ago (2015-04-24 21:52:08 UTC) #3
Dirk Pranke
as you can see, hoping to keep all of these lists in sync is a ...
5 years, 8 months ago (2015-04-24 21:55:58 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/65444)
5 years, 8 months ago (2015-04-24 22:05:32 UTC) #6
Paweł Hajdan Jr.
LGTM
5 years, 8 months ago (2015-04-24 23:46:52 UTC) #7
Dirk Pranke
On 2015/04/24 22:05:32, I haz the power (commit-bot) wrote: > Dry run: Try jobs failed ...
5 years, 8 months ago (2015-04-24 23:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106853002/20001
5 years, 8 months ago (2015-04-24 23:54:37 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-25 02:05:18 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a5319cfb4311320aa80dbc48fdc0b24192262439 Cr-Commit-Position: refs/heads/master@{#326948}
5 years, 8 months ago (2015-04-25 02:06:07 UTC) #13
sof
Tree-closing failure on "Linux GN (dbg)" appears due to this, http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN%20(dbg)/builds/12991
5 years, 8 months ago (2015-04-25 10:34:29 UTC) #15
sof
On 2015/04/25 10:34:29, sof wrote: > Tree-closing failure on "Linux GN (dbg)" appears due to ...
5 years, 8 months ago (2015-04-25 10:38:35 UTC) #16
sof
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1093313003/ by sigbjornf@opera.com. ...
5 years, 8 months ago (2015-04-25 15:20:08 UTC) #17
Dirk Pranke
5 years, 8 months ago (2015-04-25 15:47:45 UTC) #18
Message was sent while issue was closed.
On 2015/04/25 15:20:08, sof wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1093313003/ by mailto:sigbjornf@opera.com.
> 
> The reason for reverting is: Broke chromium.webkit "Linux GN (dbg)",
> 
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN%20(dbg)/build....

You probably can't revert this as-is because I partially reverted part of it
already.

Linux GN (dbg) is green on the chromium.linux waterfall, because we don't build
the failing target there.

I missed updating things on this waterfall; will do so now.

Powered by Google App Engine
This is Rietveld 408576698