Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1106763002: [iOS] Add HistoryDatabaseParamsForPath in //components/history/ios/browser (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Add HistoryDatabaseParamsForPath in //components/history/ios/browser Add new helper method to construct an HistoryDatabaseParams for a FilePath on iOS. Constants used for DownloadInterruptReason are based on the values from content/public/browser/download_interrupt_reasons.h. BUG=370850 Committed: https://crrev.com/70d2cd67184a81c7c8207de3dc0a58a2dcee2a30 Cr-Commit-Position: refs/heads/master@{#326808}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M components/history.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/history/ios/browser/history_database_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A components/history/ios/browser/history_database_helper.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sdefresne
PTAL
5 years, 8 months ago (2015-04-24 14:32:22 UTC) #2
droger
https://codereview.chromium.org/1106763002/diff/1/components/history/ios/browser/history_database_helper.cc File components/history/ios/browser/history_database_helper.cc (right): https://codereview.chromium.org/1106763002/diff/1/components/history/ios/browser/history_database_helper.cc#newcode16 components/history/ios/browser/history_database_helper.cc:16: // The download was interrupted by a browser crash. ...
5 years, 8 months ago (2015-04-24 14:38:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106763002/20001
5 years, 8 months ago (2015-04-24 14:45:23 UTC) #5
sdefresne
On 2015/04/24 14:38:29, droger wrote: > https://codereview.chromium.org/1106763002/diff/1/components/history/ios/browser/history_database_helper.cc > File components/history/ios/browser/history_database_helper.cc (right): > > https://codereview.chromium.org/1106763002/diff/1/components/history/ios/browser/history_database_helper.cc#newcode16 > ...
5 years, 8 months ago (2015-04-24 14:46:29 UTC) #6
droger
lgtm
5 years, 8 months ago (2015-04-24 14:47:29 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 15:48:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106763002/20001
5 years, 8 months ago (2015-04-24 15:58:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 15:59:22 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 16:00:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70d2cd67184a81c7c8207de3dc0a58a2dcee2a30
Cr-Commit-Position: refs/heads/master@{#326808}

Powered by Google App Engine
This is Rietveld 408576698