content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make the argument const-ref Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index c004bf0e64989b5014f4df6ac7e1f7dfd11b036e..f0adb9ef7da8bd99a7fbc9cfd0b9aba49c2acca7 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -158,7 +158,7 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

provider_host->SetDocumentUrl(GURL("http://example.com/"));

provider_host->AssociateRegistration(registration_.get(),

false /* notify_controllerchange */);

- registration_->SetActiveVersion(version_.get());

+ registration_->SetActiveVersion(version_);

ChromeBlobStorageContext* chrome_blob_storage_context =

ChromeBlobStorageContext::GetFor(browser_context_.get());

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | no next file » | no next file with comments »