content/browser/service_worker/service_worker_registration_unittest.cc - Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make the argument const-ref Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | content/browser/service_worker/service_worker_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 1965496585c3e21f3ced40beced24f8f2290ec50..d61ec06a0cb29b00d0b102fca4ed1ab76122bace 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -105,7 +105,7 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {

RegistrationListener listener;

registration->AddListener(&listener);

- registration->SetActiveVersion(version_1.get());

+ registration->SetActiveVersion(version_1);

EXPECT_EQ(version_1.get(), registration->active_version());

EXPECT_EQ(registration, listener.observed_registration_);

@@ -120,7 +120,7 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {

kInvalidServiceWorkerVersionId);

listener.Reset();

- registration->SetInstallingVersion(version_2.get());

+ registration->SetInstallingVersion(version_2);

EXPECT_EQ(version_2.get(), registration->installing_version());

EXPECT_EQ(ChangedVersionAttributesMask::INSTALLING_VERSION,

@@ -132,7 +132,7 @@ TEST_F(ServiceWorkerRegistrationTest, SetAndUnsetVersions) {

kInvalidServiceWorkerVersionId);

listener.Reset();

- registration->SetWaitingVersion(version_2.get());

+ registration->SetWaitingVersion(version_2);

EXPECT_EQ(version_2.get(), registration->waiting_version());

EXPECT_FALSE(registration->installing_version());