content/browser/service_worker/service_worker_job_unittest.cc - Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 1106723002: ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make the argument const-ref Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc ('k') | content/browser/service_worker/service_worker_registration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index 2c936f2daed1bd27ccea9bbff5661574f428bed7..9e1b187dc2cf13c43cd47860e50f248070ba9e67 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -648,7 +648,7 @@ TEST_F(ServiceWorkerJobTest, UnregisterWaitingSetsRedundant) {

ASSERT_EQ(SERVICE_WORKER_OK, status);

version->SetStatus(ServiceWorkerVersion::INSTALLED);

- registration->SetWaitingVersion(version.get());

+ registration->SetWaitingVersion(version);

EXPECT_EQ(ServiceWorkerVersion::RUNNING,

version->running_status());

EXPECT_EQ(ServiceWorkerVersion::INSTALLED, version->status());

@@ -1030,7 +1030,7 @@ TEST_F(ServiceWorkerJobTest, Update_NewestVersionChanged) {

GURL("http://www.example.com/new_worker.js"),

2L /* dummy version id */,

helper_->context()->AsWeakPtr());

- registration->SetWaitingVersion(version.get());

+ registration->SetWaitingVersion(version);

base::RunLoop().RunUntilIdle();