ServiceWorker: Decompose SWRegistration::SetVersionInternal for readability

content/browser/service_worker/service_worker_registration.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 76 matching lines @@
   void AddListener(Listener* listener);
   void RemoveListener(Listener* listener);
   void NotifyRegistrationFailed();
   void NotifyUpdateFound();
 
   ServiceWorkerRegistrationInfo GetInfo();
 
   // Sets the corresposding version attribute and resets the position
   // (if any) left vacant (ie. by a waiting version being promoted).
   // Also notifies listeners via OnVersionAttributesChanged.
-  void SetActiveVersion(ServiceWorkerVersion* version);
-  void SetWaitingVersion(ServiceWorkerVersion* version);
-  void SetInstallingVersion(ServiceWorkerVersion* version);
+  void SetActiveVersion(const scoped_refptr<ServiceWorkerVersion>& version);
+  void SetWaitingVersion(const scoped_refptr<ServiceWorkerVersion>& version);
+  void SetInstallingVersion(const scoped_refptr<ServiceWorkerVersion>& version);
 
   // If version is the installing, waiting, active version of this
   // registation, the method will reset that field to NULL, and notify
   // listeners via OnVersionAttributesChanged.
   void UnsetVersion(ServiceWorkerVersion* version);
 
   // Triggers the [[Activate]] algorithm when the currently active version
   // has no controllees. If there are no controllees at the time the method
   // is called or when version's skip waiting flag is set, activation is
   // initiated immediately.
@@ skipping 25 matching lines @@
                      const std::string& data,
                      const StatusCallback& callback);
   void ClearUserData(const std::string& key,
                      const StatusCallback& callback);
 
  private:
   friend class base::RefCounted<ServiceWorkerRegistration>;
 
   ~ServiceWorkerRegistration() override;
 
-  void SetVersionInternal(
-      ServiceWorkerVersion* version,
-      scoped_refptr<ServiceWorkerVersion>* data_member,
-      int change_flag);
   void UnsetVersionInternal(
       ServiceWorkerVersion* version,
       ChangedVersionAttributesMask* mask);
 
   // ServiceWorkerVersion::Listener override.
   void OnNoControllees(ServiceWorkerVersion* version) override;
 
   // This method corresponds to the [[Activate]] algorithm.
   void ActivateWaitingVersion();
   void OnActivateEventFinished(
@@ skipping 21 matching lines @@
   scoped_refptr<ServiceWorkerVersion> installing_version_;
   ObserverList<Listener> listeners_;
   base::WeakPtr<ServiceWorkerContextCore> context_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegistration);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_