Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1106713002: Revert of [es6] Map/Set size getter should have "get size" name (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
caitp (gmail), adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Map/Set size getter should have "get size" name (patchset #4 id:80001 of https://codereview.chromium.org/1094323005/) Reason for revert: Breaks GCMole ia32 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1685/steps/GCMole%20ia32/logs/stdio src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order. f->shared()->set_name(*NameToFunctionName(name)); ^ src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order. 2 warnings generated. Original issue's description: > [es6] Map/Set size getter should have "get size" name > > Getter and setter function names in ES6 are defined as "get foo" and > "set foo". > > BUG=None > LOG=N > R=adamk@chromium.org > > Committed: https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42 > Cr-Commit-Position: refs/heads/master@{#28034} TBR=adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/d5565c1f689b2953d92abd350529363f04f90fcd Cr-Commit-Position: refs/heads/master@{#28035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 2 chunks +3 lines, -6 lines 0 comments Download
D test/mjsunit/es6/built-in-accessor-names.js View 1 chunk +0 lines, -51 lines 0 comments Download
M test/mjsunit/es6/collections.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of [es6] Map/Set size getter should have "get size" name
5 years, 8 months ago (2015-04-23 22:06:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106713002/1
5 years, 8 months ago (2015-04-23 22:06:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:06:50 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:07:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5565c1f689b2953d92abd350529363f04f90fcd
Cr-Commit-Position: refs/heads/master@{#28035}

Powered by Google App Engine
This is Rietveld 408576698