Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 1106673002: Swap the main frame in --site-per-process mode too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1194 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 // It is now safe to show modal dialogs again. 1205 // It is now safe to show modal dialogs again.
1206 // TODO(creis): Deal with modal dialogs from subframes. 1206 // TODO(creis): Deal with modal dialogs from subframes.
1207 if (is_main_frame) 1207 if (is_main_frame)
1208 render_view_->suppress_dialogs_until_swap_out_ = false; 1208 render_view_->suppress_dialogs_until_swap_out_ = false;
1209 1209
1210 Send(new FrameHostMsg_SwapOut_ACK(routing_id_)); 1210 Send(new FrameHostMsg_SwapOut_ACK(routing_id_));
1211 1211
1212 // Now that all of the cleanup is complete and the browser side is notified, 1212 // Now that all of the cleanup is complete and the browser side is notified,
1213 // start using the RenderFrameProxy, if one is created. 1213 // start using the RenderFrameProxy, if one is created.
1214 if (proxy) { 1214 if (proxy) {
1215 if (!is_main_frame) { 1215 if (!is_main_frame || is_site_per_process) {
1216 frame_->swap(proxy->web_frame()); 1216 frame_->swap(proxy->web_frame());
1217 1217
1218 if (is_loading) 1218 if (is_loading)
1219 proxy->OnDidStartLoading(); 1219 proxy->OnDidStartLoading();
1220 1220
1221 if (is_site_per_process) { 1221 if (is_site_per_process) {
1222 // TODO(nasko): delete the frame here, since we've replaced it with a 1222 // TODO(nasko): delete the frame here, since we've replaced it with a
1223 // proxy. 1223 // proxy.
1224 } 1224 }
1225 } 1225 }
(...skipping 3691 matching lines...) Expand 10 before | Expand all | Expand 10 after
4917 #elif defined(ENABLE_BROWSER_CDMS) 4917 #elif defined(ENABLE_BROWSER_CDMS)
4918 cdm_manager_, 4918 cdm_manager_,
4919 #endif 4919 #endif
4920 this); 4920 this);
4921 } 4921 }
4922 4922
4923 return cdm_factory_; 4923 return cdm_factory_;
4924 } 4924 }
4925 4925
4926 } // namespace content 4926 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698