Flip extension background page throttling on by default

Flip extension background page throttling on by default

R=kalman
BUG=424661
Committed: https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd
Cr-Commit-Position: refs/heads/master@{#326953}

[not at google - send to devlin, 2015-04-23 18:35:04]

lgtm

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
File extensions/browser/extension_host.cc (right):

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
extensions/browser/extension_host.cc:156: if
(base::FieldTrialList::FindFullName(
btw is looking up a field trial at all expensive? because the
HasPersistentBackgroundPage isn't at all... and I actually think it reads more
naturally if you check that first anyway.

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
extensions/browser/extension_host.cc:157: "ThrottleExtensionBackgroundPages") !=
"disabled" &&
kinda weird that the case here changed, from "ThrottlePersistent"/"ThrottleAll"
to "disabled", but just an observation.

[oystein (OOO til 10th of July), 2015-04-23 18:37:28]

Thanks!

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
File extensions/browser/extension_host.cc (right):

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
extensions/browser/extension_host.cc:156: if
(base::FieldTrialList::FindFullName(
On 2015/04/23 18:35:04, kalman wrote:
> btw is looking up a field trial at all expensive? because the
> HasPersistentBackgroundPage isn't at all... and I actually think it reads more
> naturally if you check that first anyway.

Agreed; done.

https://codereview.chromium.org/1106653002/diff/1/extensions/browser/extensio...
extensions/browser/extension_host.cc:157: "ThrottleExtensionBackgroundPages") !=
"disabled" &&
On 2015/04/23 18:35:04, kalman wrote:
> kinda weird that the case here changed, from
"ThrottlePersistent"/"ThrottleAll"
> to "disabled", but just an observation.

Fair enough :). Changed to "Disabled"

[oystein (OOO til 10th of July), 2015-04-23 18:37:33]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2015-04-23 18:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1106653002/#ps20001
(title: "Review fixes")

[commit-bot: I haz the power, 2015-04-23 18:40:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106653002/20001

[commit-bot: I haz the power, 2015-04-23 21:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 21:12:01]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oystein (OOO til 10th of July), 2015-04-23 21:27:16]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2015-04-23 21:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106653002/20001

[commit-bot: I haz the power, 2015-04-23 23:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 23:57:00]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oystein (OOO til 10th of July), 2015-04-25 00:48:44]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2015-04-25 00:49:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1106653002/20001

[commit-bot: I haz the power, 2015-04-25 02:44:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-25 02:44:51]

Patchset 2 (id:??) landed as
https://crrev.com/34ea66b8ac1d56dadd670a9f5f8431063857ffdd
Cr-Commit-Position: refs/heads/master@{#326953}

[Nikita (slow), 2015-04-27 09:45:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1106953002/ by nkostylev@chromium.org.

The reason for reverting is: Speculative revert - multiple browser_tests fail on
Mac10.9 Tests (dbg) 
http://goo.gl/4AqhVG.

[oystein (OOO til 10th of July), 2015-04-27 20:24:14]

Patchset #3 (id:40001) has been deleted