tools/js2c.py - Issue 1106633002: Wrap messages implementation in a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/js2c.py

Issue 1106633002: Wrap messages implementation in a function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@messages_5

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/js2c.py

diff --git a/tools/js2c.py b/tools/js2c.py

index e913ca1e3996bd8fee619bf26e3a76ec1b5e2e9a..697a403c4fb5a2a3d7f26d363c6a5aeebd2e3d77 100755

--- a/tools/js2c.py

+++ b/tools/js2c.py

@@ -69,7 +69,7 @@ def ReadFile(filename):

EVAL_PATTERN = re.compile(r'\beval\s*\(')

WITH_PATTERN = re.compile(r'\bwith\s*\(')

-INVALID_ERROR_MESSAGE_PATTERN = re.compile(r'Make\w*Error\(([kA-Z]\w+)')

+INVALID_ERROR_MESSAGE_PATTERN = re.compile(r'Make(?!Generic)\w*Error\(([kA-Z]\w+)')

Jakob Kummerow 2015/04/23 12:09:21 nit: 80col Pro tip: break after '(', then you don

NEW_ERROR_PATTERN = re.compile(r'new \$\w*Error$(?!$)');

def Validate(lines):

« src/messages.js ('K') | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »