Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 110663003: Remove uses of deprecated toWebCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/JavaScriptCallFrame.cpp
diff --git a/Source/core/inspector/JavaScriptCallFrame.cpp b/Source/core/inspector/JavaScriptCallFrame.cpp
index ae2d659d8a8dee3175699a56178a529839ae59be..4dcfd1e2afd09382bb09f3b1eb5ef44208ddcdb4 100644
--- a/Source/core/inspector/JavaScriptCallFrame.cpp
+++ b/Source/core/inspector/JavaScriptCallFrame.cpp
@@ -97,7 +97,8 @@ String JavaScriptCallFrame::functionName() const
v8::HandleScope handleScope(m_isolate);
v8::Context::Scope contextScope(m_debuggerContext.newLocal(m_isolate));
v8::Handle<v8::Value> result = m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "functionName"));
- return toWebCoreStringWithUndefinedOrNullCheck(result);
+ V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithUndefinedOrNullCheck>, name, result, String());
+ return name;
}
v8::Handle<v8::Value> JavaScriptCallFrame::scopeChain() const
@@ -125,7 +126,8 @@ String JavaScriptCallFrame::stepInPositions() const
v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
v8::Handle<v8::Function> stepInPositions = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "stepInPositions")));
v8::Handle<v8::Value> result = stepInPositions->Call(callFrame, 0, 0);
- return toWebCoreStringWithUndefinedOrNullCheck(result);
+ V8TRYCATCH_FOR_V8STRINGRESOURCE_RETURN(V8StringResource<WithUndefinedOrNullCheck>, resultString, result, String());
+ return resultString;
}
bool JavaScriptCallFrame::isAtReturn() const
« no previous file with comments | « Source/bindings/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698