Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1106623003: DevTools: render ParseHTML details in timeline: url, start and end lines. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 break; 250 break;
251 case recordType.TimerInstall: 251 case recordType.TimerInstall:
252 case recordType.TimerRemove: 252 case recordType.TimerRemove:
253 detailsText = linkifyTopCallFrameAsText() || eventData["timerId"]; 253 detailsText = linkifyTopCallFrameAsText() || eventData["timerId"];
254 break; 254 break;
255 case recordType.RequestAnimationFrame: 255 case recordType.RequestAnimationFrame:
256 case recordType.CancelAnimationFrame: 256 case recordType.CancelAnimationFrame:
257 detailsText = linkifyTopCallFrameAsText() || eventData["id"]; 257 detailsText = linkifyTopCallFrameAsText() || eventData["id"];
258 break; 258 break;
259 case recordType.ParseHTML: 259 case recordType.ParseHTML:
260 var endLine = event.args["endData"]["endLine"];
261 var url = event.args["beginData"]["url"];
262 detailsText = endLine ? WebInspector.UIString("%s [%d:%d]", url, event.a rgs["beginData"]["startLine"] + 1, endLine + 1) : url;
263 break;
260 case recordType.RecalculateStyles: 264 case recordType.RecalculateStyles:
261 detailsText = linkifyTopCallFrameAsText(); 265 detailsText = linkifyTopCallFrameAsText();
262 break; 266 break;
263 case recordType.EvaluateScript: 267 case recordType.EvaluateScript:
264 var url = eventData["url"]; 268 var url = eventData["url"];
265 if (url) 269 if (url)
266 detailsText = url + ":" + eventData["lineNumber"]; 270 detailsText = url + ":" + eventData["lineNumber"];
267 break; 271 break;
268 case recordType.XHRReadyStateChange: 272 case recordType.XHRReadyStateChange:
269 case recordType.XHRLoad: 273 case recordType.XHRLoad:
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 case recordType.ResizeImage: 370 case recordType.ResizeImage:
367 case recordType.DecodeLazyPixelRef: 371 case recordType.DecodeLazyPixelRef:
368 case recordType.Animation: 372 case recordType.Animation:
369 case recordType.XHRReadyStateChange: 373 case recordType.XHRReadyStateChange:
370 case recordType.XHRLoad: 374 case recordType.XHRLoad:
371 case recordType.ResourceSendRequest: 375 case recordType.ResourceSendRequest:
372 case recordType.ResourceReceivedData: 376 case recordType.ResourceReceivedData:
373 case recordType.ResourceReceiveResponse: 377 case recordType.ResourceReceiveResponse:
374 case recordType.ResourceFinish: 378 case recordType.ResourceFinish:
375 case recordType.EmbedderCallback: 379 case recordType.EmbedderCallback:
380 case recordType.ParseHTML:
376 detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent (event, target); 381 detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent (event, target);
377 break; 382 break;
378 case recordType.FunctionCall: 383 case recordType.FunctionCall:
379 details = linkifyLocation(eventData["scriptId"], eventData["scriptName"] , eventData["scriptLine"], 0); 384 details = linkifyLocation(eventData["scriptId"], eventData["scriptName"] , eventData["scriptLine"], 0);
380 break; 385 break;
381 case recordType.JSFrame: 386 case recordType.JSFrame:
382 details = createElement("span"); 387 details = createElement("span");
383 details.createTextChild(WebInspector.beautifyFunctionName(eventData["fun ctionName"])); 388 details.createTextChild(WebInspector.beautifyFunctionName(eventData["fun ctionName"]));
384 var location = linkifyLocation(eventData["scriptId"], eventData["url"], eventData["lineNumber"], eventData["columnNumber"]); 389 var location = linkifyLocation(eventData["scriptId"], eventData["url"], eventData["lineNumber"], eventData["columnNumber"]);
385 if (location) { 390 if (location) {
386 details.createTextChild(" @ "); 391 details.createTextChild(" @ ");
387 details.appendChild(location); 392 details.appendChild(location);
388 } 393 }
389 break; 394 break;
390 case recordType.TimerInstall: 395 case recordType.TimerInstall:
391 case recordType.TimerRemove: 396 case recordType.TimerRemove:
392 details = linkifyTopCallFrame(); 397 details = linkifyTopCallFrame();
393 detailsText = eventData["timerId"]; 398 detailsText = eventData["timerId"];
394 break; 399 break;
395 case recordType.RequestAnimationFrame: 400 case recordType.RequestAnimationFrame:
396 case recordType.CancelAnimationFrame: 401 case recordType.CancelAnimationFrame:
397 details = linkifyTopCallFrame(); 402 details = linkifyTopCallFrame();
398 detailsText = eventData["id"]; 403 detailsText = eventData["id"];
399 break; 404 break;
400 case recordType.ParseHTML:
401 case recordType.RecalculateStyles: 405 case recordType.RecalculateStyles:
402 details = linkifyTopCallFrame(); 406 details = linkifyTopCallFrame();
403 break; 407 break;
404 case recordType.EvaluateScript: 408 case recordType.EvaluateScript:
405 var url = eventData["url"]; 409 var url = eventData["url"];
406 if (url) 410 if (url)
407 details = linkifyLocation("", url, eventData["lineNumber"], 0); 411 details = linkifyLocation("", url, eventData["lineNumber"], 0);
408 break; 412 break;
409 default: 413 default:
410 if (event.category === WebInspector.TracingModel.ConsoleEventCategory) 414 if (event.category === WebInspector.TracingModel.ConsoleEventCategory)
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 if (typeof eventData["message"] !== "undefined") 630 if (typeof eventData["message"] !== "undefined")
627 contentHelper.appendTextRow(WebInspector.UIString("Message"), eventD ata["message"]); 631 contentHelper.appendTextRow(WebInspector.UIString("Message"), eventD ata["message"]);
628 break; 632 break;
629 case recordTypes.EmbedderCallback: 633 case recordTypes.EmbedderCallback:
630 contentHelper.appendTextRow(WebInspector.UIString("Callback Function"), eventData["callbackName"]); 634 contentHelper.appendTextRow(WebInspector.UIString("Callback Function"), eventData["callbackName"]);
631 break; 635 break;
632 case recordTypes.Animation: 636 case recordTypes.Animation:
633 if (event.phase === WebInspector.TracingModel.Phase.NestableAsyncInstant ) 637 if (event.phase === WebInspector.TracingModel.Phase.NestableAsyncInstant )
634 contentHelper.appendTextRow(WebInspector.UIString("State"), eventDat a["state"]); 638 contentHelper.appendTextRow(WebInspector.UIString("State"), eventDat a["state"]);
635 break; 639 break;
640 case recordTypes.ParseHTML:
641 var beginData = event.args["beginData"];
642 var url = beginData["url"];
643 if (url)
644 contentHelper.appendTextRow(WebInspector.UIString("URL"), url);
645 var startLine = beginData["startLine"] + 1;
646 var endLine = event.args["endData"]["endLine"] + 1;
647 if (endLine)
648 contentHelper.appendTextRow(WebInspector.UIString("Range"), WebInspe ctor.UIString("%d \u2014 %d", startLine, endLine));
649 break;
636 default: 650 default:
637 var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceE vent(event, model.target(), linkifier); 651 var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceE vent(event, model.target(), linkifier);
638 if (detailsNode) 652 if (detailsNode)
639 contentHelper.appendElementRow(WebInspector.UIString("Details"), det ailsNode); 653 contentHelper.appendElementRow(WebInspector.UIString("Details"), det ailsNode);
640 break; 654 break;
641 } 655 }
642 656
643 var relatedNode = contentHelper.nodeForBackendId(event.backendNodeId); 657 var relatedNode = contentHelper.nodeForBackendId(event.backendNodeId);
644 if (relatedNode) 658 if (relatedNode)
645 contentHelper.appendElementRow(relatedNodeLabel || WebInspector.UIString ("Related node"), WebInspector.DOMPresentationUtils.linkifyNodeReference(related Node)); 659 contentHelper.appendElementRow(relatedNodeLabel || WebInspector.UIString ("Related node"), WebInspector.DOMPresentationUtils.linkifyNodeReference(related Node));
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1863 return; 1877 return;
1864 1878
1865 var stackTraceElement = parentElement.createChild("div", "timeline-detai ls-view-row-value timeline-details-view-row-stack-trace monospace"); 1879 var stackTraceElement = parentElement.createChild("div", "timeline-detai ls-view-row-value timeline-details-view-row-stack-trace monospace");
1866 1880
1867 var callFrameElem = WebInspector.DOMPresentationUtils.buildStackTracePre viewContents(this._target, this._linkifier, stackTrace); 1881 var callFrameElem = WebInspector.DOMPresentationUtils.buildStackTracePre viewContents(this._target, this._linkifier, stackTrace);
1868 1882
1869 stackTraceElement.appendChild(callFrameElem); 1883 stackTraceElement.appendChild(callFrameElem);
1870 } 1884 }
1871 1885
1872 } 1886 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698