DevTools: render ParseHTML details in timeline: url, start and end lines.

Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 239 matching lines @@
         break;
     case recordType.TimerInstall:
     case recordType.TimerRemove:
         detailsText = linkifyTopCallFrameAsText() || eventData["timerId"];
         break;
     case recordType.RequestAnimationFrame:
     case recordType.CancelAnimationFrame:
         detailsText = linkifyTopCallFrameAsText() || eventData["id"];
         break;
     case recordType.ParseHTML:
+        var endLine = event.args["endLine"];

[alph, 2015/04/27 10:04:34]

It should be placed into args["data"]["endLine"] ?

[pfeldman, 2015/04/27 11:52:51]

Done.

+        var url = event.args["beginData"]["url"];
+        if (endLine)
+            detailsText = WebInspector.UIString("%s [%d:%d]", url, event.args["beginData"]["startLine"] + 1, endLine);

[alph, 2015/04/27 10:04:34]

Use ?: please.

[pfeldman, 2015/04/27 11:52:51]

Done.

+        else
+            detailsText = url;
+        break;
     case recordType.RecalculateStyles:
         detailsText = linkifyTopCallFrameAsText();
         break;
     case recordType.EvaluateScript:
         var url = eventData["url"];
         if (url)
             detailsText = url + ":" + eventData["lineNumber"];
         break;
     case recordType.XHRReadyStateChange:
     case recordType.XHRLoad:
@@ skipping 96 matching lines @@
     case recordType.ResizeImage:
     case recordType.DecodeLazyPixelRef:
     case recordType.Animation:
     case recordType.XHRReadyStateChange:
     case recordType.XHRLoad:
     case recordType.ResourceSendRequest:
     case recordType.ResourceReceivedData:
     case recordType.ResourceReceiveResponse:
     case recordType.ResourceFinish:
     case recordType.EmbedderCallback:
+    case recordType.ParseHTML:
         detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, target);
         break;
     case recordType.FunctionCall:
         details = linkifyLocation(eventData["scriptId"], eventData["scriptName"], eventData["scriptLine"], 0);
         break;
     case recordType.JSFrame:
         details = createElement("span");
         details.createTextChild(WebInspector.beautifyFunctionName(eventData["functionName"]));
         var location = linkifyLocation(eventData["scriptId"], eventData["url"], eventData["lineNumber"], eventData["columnNumber"]);
         if (location) {
            details.createTextChild(" @ ");
            details.appendChild(location);
         }
         break;
     case recordType.TimerInstall:
     case recordType.TimerRemove:
         details = linkifyTopCallFrame();
         detailsText = eventData["timerId"];
         break;
     case recordType.RequestAnimationFrame:
     case recordType.CancelAnimationFrame:
         details = linkifyTopCallFrame();
         detailsText = eventData["id"];
         break;
-    case recordType.ParseHTML:
     case recordType.RecalculateStyles:
         details = linkifyTopCallFrame();
         break;
     case recordType.EvaluateScript:
         var url = eventData["url"];
         if (url)
             details = linkifyLocation("", url, eventData["lineNumber"], 0);
         break;
     default:
         if (event.category === WebInspector.TracingModel.ConsoleEventCategory)
@@ skipping 215 matching lines @@
         if (typeof eventData["message"] !== "undefined")
             contentHelper.appendTextRow(WebInspector.UIString("Message"), eventData["message"]);
         break;
     case recordTypes.EmbedderCallback:
         contentHelper.appendTextRow(WebInspector.UIString("Callback Function"), eventData["callbackName"]);
         break;
     case recordTypes.Animation:
         if (event.phase === WebInspector.TracingModel.Phase.NestableAsyncInstant)
             contentHelper.appendTextRow(WebInspector.UIString("State"), eventData["state"]);
         break;
+    case recordTypes.ParseHTML:
+        var beginData = event.args["beginData"];
+        var url = beginData["url"];
+        if (url)
+            contentHelper.appendTextRow(WebInspector.UIString("URL"), url);
+        var startLine = beginData["startLine"] + 1;

[alph, 2015/04/27 10:04:34]

Why startLine needs +1, but endLine does not? Could you please make it uniform.

[pfeldman, 2015/04/27 11:52:51]

Done.

+        var endLine = event.args["endLine"];
+        if (endLine)
+            contentHelper.appendTextRow(WebInspector.UIString("Range"), WebInspector.UIString("%d \u2014 %d", startLine, endLine));
+        break;
     default:
         var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, model.target(), linkifier);
         if (detailsNode)
             contentHelper.appendElementRow(WebInspector.UIString("Details"), detailsNode);
         break;
     }
 
     var relatedNode = contentHelper.nodeForBackendId(event.backendNodeId);
     if (relatedNode)
         contentHelper.appendElementRow(relatedNodeLabel || WebInspector.UIString("Related node"), WebInspector.DOMPresentationUtils.linkifyNodeReference(relatedNode));
@@ skipping 1217 matching lines @@
             return;
 
         var stackTraceElement = parentElement.createChild("div", "timeline-details-view-row-value timeline-details-view-row-stack-trace monospace");
 
         var callFrameElem = WebInspector.DOMPresentationUtils.buildStackTracePreviewContents(this._target, this._linkifier, stackTrace);
 
         stackTraceElement.appendChild(callFrameElem);
     }
 
 }