Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1106623003: DevTools: render ParseHTML details in timeline: url, start and end lines. (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: render ParseHTML details in timeline: url, start and end lines. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194513

Patch Set 1 #

Total comments: 6

Patch Set 2 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M LayoutTests/inspector/tracing/timeline-parse-html-expected.txt View 1 2 chunks +8 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
5 years, 8 months ago (2015-04-24 17:53:56 UTC) #2
alph
https://codereview.chromium.org/1106623003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/1106623003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode260 Source/devtools/front_end/timeline/TimelineUIUtils.js:260: var endLine = event.args["endLine"]; It should be placed into ...
5 years, 8 months ago (2015-04-27 10:04:34 UTC) #4
pfeldman
https://codereview.chromium.org/1106623003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/1106623003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode260 Source/devtools/front_end/timeline/TimelineUIUtils.js:260: var endLine = event.args["endLine"]; On 2015/04/27 10:04:34, alph wrote: ...
5 years, 8 months ago (2015-04-27 11:52:51 UTC) #5
alph
lgtm
5 years, 8 months ago (2015-04-27 12:24:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106623003/20001
5 years, 8 months ago (2015-04-27 12:25:46 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 13:35:59 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194513

Powered by Google App Engine
This is Rietveld 408576698