src/compiler/pipeline.cc - Issue 1106613003: [turbofan] Unify frame state inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/pipeline.cc

Issue 1106613003: [turbofan] Unify frame state inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/pipeline.cc

diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc

index 0d28dafb708d5f50121a4c8ee14c216c912218f4..022b6b5d1b2fb4eb24519d825f8548a2dde44d9c 100644

--- a/src/compiler/pipeline.cc

+++ b/src/compiler/pipeline.cc

@@ -1042,7 +1042,9 @@ Handle<Code> Pipeline::GenerateCode() {

RunPrintAndVerify("OSR deconstruction");

}

- if (info()->is_type_feedback_enabled()) {

+ // TODO(turbofan): Type feedback currently requires deoptimization.

+ if (info()->is_deoptimization_enabled() &&

+ info()->is_type_feedback_enabled()) {

Run<JSTypeFeedbackPhase>();

RunPrintAndVerify("JSType feedback");

}