Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: src/compiler/graph-replay.cc

Issue 1106613003: [turbofan] Unify frame state inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph.h ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-replay.cc
diff --git a/src/compiler/graph-replay.cc b/src/compiler/graph-replay.cc
index 06771ff8244d4cb21c64ce3469f0653fea1405a6..7f4cc95d91b0cf3c2a692165a9e78217df20d290 100644
--- a/src/compiler/graph-replay.cc
+++ b/src/compiler/graph-replay.cc
@@ -19,14 +19,14 @@ namespace compiler {
void GraphReplayPrinter::PrintReplay(Graph* graph) {
GraphReplayPrinter replay;
- PrintF(" Node* nil = graph.NewNode(common_builder.Dead());\n");
+ PrintF(" Node* nil = graph()->NewNode(common()->Dead());\n");
Zone zone;
AllNodes nodes(&zone, graph);
// Allocate the nodes first.
for (Node* node : nodes.live) {
PrintReplayOpCreator(node->op());
- PrintF(" Node* n%d = graph.NewNode(op", node->id());
+ PrintF(" Node* n%d = graph()->NewNode(op", node->id());
for (int i = 0; i < node->InputCount(); ++i) {
PrintF(", nil");
}
@@ -45,24 +45,25 @@ void GraphReplayPrinter::PrintReplay(Graph* graph) {
void GraphReplayPrinter::PrintReplayOpCreator(const Operator* op) {
IrOpcode::Value opcode = static_cast<IrOpcode::Value>(op->opcode());
- const char* builder =
- IrOpcode::IsCommonOpcode(opcode) ? "common_builder" : "js_builder";
+ const char* builder = IrOpcode::IsCommonOpcode(opcode) ? "common" : "js";
const char* mnemonic = IrOpcode::IsCommonOpcode(opcode)
? IrOpcode::Mnemonic(opcode)
: IrOpcode::Mnemonic(opcode) + 2;
- PrintF(" op = %s.%s(", builder, mnemonic);
+ PrintF(" op = %s()->%s(", builder, mnemonic);
switch (opcode) {
case IrOpcode::kParameter:
- case IrOpcode::kNumberConstant:
- PrintF("0");
+ PrintF("%d", ParameterIndexOf(op));
break;
- case IrOpcode::kLoad:
- PrintF("unique_name");
+ case IrOpcode::kNumberConstant:
+ PrintF("%g", OpParameter<double>(op));
break;
case IrOpcode::kHeapConstant:
PrintF("unique_constant");
break;
case IrOpcode::kPhi:
+ PrintF("kMachAnyTagged, %d", op->ValueInputCount());
+ break;
+ case IrOpcode::kStateValues:
PrintF("%d", op->ValueInputCount());
break;
case IrOpcode::kEffectPhi:
@@ -72,6 +73,12 @@ void GraphReplayPrinter::PrintReplayOpCreator(const Operator* op) {
case IrOpcode::kMerge:
PrintF("%d", op->ControlInputCount());
break;
+ case IrOpcode::kStart:
+ PrintF("%d", op->ValueOutputCount() - 3);
+ break;
+ case IrOpcode::kFrameState:
+ PrintF("JS_FRAME, BailoutId(-1), OutputFrameStateCombine::Ignore()");
+ break;
default:
break;
}
@@ -79,6 +86,7 @@ void GraphReplayPrinter::PrintReplayOpCreator(const Operator* op) {
}
#endif // DEBUG
-}
-}
-} // namespace v8::internal::compiler
+
+} // namespace compiler
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/compiler/graph.h ('k') | src/compiler/instruction-selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698