Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11066125: Check that the user is signed in and the app has oauth2 section before recording an aouth2 grant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
===================================================================
--- chrome/browser/extensions/extension_service.cc (revision 161131)
+++ chrome/browser/extensions/extension_service.cc (working copy)
@@ -2078,11 +2078,8 @@
// Silently grant all active permissions to default apps only on install.
// After install they should behave like other apps.
- if (is_default_app_install) {
- // Not recording any OAuth2 grants since no default apps need them. See
- // http://crbug.com/154896 for a better way of checking this.
- GrantPermissions(extension, false);
- }
+ if (is_default_app_install)
+ GrantPermissions(extension, true);
if (is_extension_upgrade) {
// Other than for unpacked extensions, CrxInstaller should have guaranteed
« no previous file with comments | « no previous file | chrome/browser/extensions/permissions_updater.cc » ('j') | chrome/browser/extensions/permissions_updater.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698